Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring VRMShaders directory & asmdef #854

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Refactoring VRMShaders directory & asmdef #854

merged 1 commit into from
Apr 8, 2021

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Apr 8, 2021 •
edited
Loading

VRMShaders の構造をリファクタリング。

  • Assets/VRMShaders/ 直下は対象 ( GLTF or VRM or VRM10 ) を明確に分離。
  • 各対象ごとにパッケージを切る。
  • パッケージごとに Runtime or Editor or Tests のディレクトリと asmdef を切る。
  • VRMShaders 以下の asmdef は Auto Referenced を切り、明示的な依存関係を構築する。

@Santarh Santarh requested a review from ousttrue April 8, 2021 11:21
ousttrue
ousttrue approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@ousttrue ousttrue merged commit 63bbace into vrm-c:master Apr 8, 2021
@ousttrue
Copy link
Contributor

#496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Santarh @ousttrue