Feature/mesh validator #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
May 6, 2021
ousttrue
commented
- Materials.Length==0 または Materials.Contains(null) の場合は、メッセージを表示して、エクスポートボタンを押せないようにする #919 の実装
- gltf, vrm0, vrm1 で共有
Santarh
approved these changes
May 6, 2021
| UNKNOWN_SHADER, | ||
| } | ||
|
|
||
| public IEnumerable<Validation> Validate(GameObject ExportRoot) |
| if (info.Renderer.sharedMaterials.Length < info.Mesh.subMeshCount) | ||
| { | ||
| // すべての submesh に material が割り当てられていない | ||
| yield return Validation.Error(Messages.DIFFERENT_MATERIAL_COUNT.Msg()); |
| else if (info.Renderer.sharedMaterials.Length > info.Mesh.subMeshCount) | ||
| { | ||
| // 未使用の material がある | ||
| yield return Validation.Warning(Messages.DIFFERENT_MATERIAL_COUNT.Msg()); |
There was a problem hiding this comment.
👍
Unity の挙動としては正確には
「末尾の submesh を利用した重複描画の material がある」
とかかな
| else if (info.Renderer.sharedMaterials.Any(x => x == null)) | ||
| { | ||
| // material に null が含まれる(unity で magenta になっているはず) | ||
| yield return Validation.Error($"{info.Renderer}: {Messages.MATERIALS_CONTAINS_NULL.Msg()}"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.