container create: do not clear image name

When creating a container, do not clear the input-image name before looking up image names. Also add a regression test. Fixes: containers#8558 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg · Dec 7, 2020 · f294d89 · f294d89
1 parent 035d289
commit f294d89
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/pkg/specgen/generate/container_create.go b/pkg/specgen/generate/container_create.go
@@ -98,7 +98,6 @@ func MakeContainer(ctx context.Context, rt *libpod.Runtime, s *specgen.SpecGener
 		// present.
 		imgName := newImage.InputName
 		if s.Image == newImage.InputName && strings.HasPrefix(newImage.ID(), s.Image) {
-			imgName = ""
 			names := newImage.Names()
 			if len(names) > 0 {
 				imgName = names[0]

diff --git a/test/system/030-run.bats b/test/system/030-run.bats
@@ -536,6 +536,17 @@ json-file | f
     run_podman untag $IMAGE $newtag $newtag2
 }
 
+# Regression test for issue #8558
+@test "podman run on untagged image: make sure that image metadata is set" {
+    run_podman inspect $IMAGE --format "{{.ID}}"
+    imageID="$output"
+
+    run_podman untag $IMAGE
+    run_podman run --rm $imageID ls
+
+    run_podman tag $imageID $IMAGE
+}
+
 @test "Verify /run/.containerenv exist" {
 	run_podman run --rm $IMAGE ls -1 /run/.containerenv
 	is "$output" "/run/.containerenv"