Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 I18n: add missing translations #139

Merged

Conversation

Christopher-Hayes
Copy link
Member

@Christopher-Hayes Christopher-Hayes commented Oct 20, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced localization support with new prompts and instructions across multiple languages.
    • Added custom prompt configuration options for user interactions.
  • Bug Fixes

    • Improved handling of model selection feedback messages.
  • Documentation

    • Updated translation keys for better clarity and usability in the user interface.
  • Refactor

    • Removed hardcoded strings in components, replacing them with localized strings for better internationalization.
  • Chores

    • Cleaned up commented-out code in the IntroductionSplash component.

@Christopher-Hayes Christopher-Hayes linked an issue Oct 20, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Oct 20, 2024

Caution

Review failed

The head commit changed during the review from 01639de to d511ddd.

Walkthrough

The pull request includes significant updates to localization files and the package.json for the chatgpt-reborn project. Key changes involve adding new localized strings across multiple languages to enhance user interaction and guidance, particularly in the context of model selection and question input. Additionally, the package.json file has been modified to support localization for UI elements and introduce new configuration options for custom prompts.

Changes

File Path Change Summary
package.json - Updated view name from "Chat" to a localized string.
- Added properties for custom prompt configuration: chatgpt.promptPrefix.customPrompt6 and its enablement flag.
package.nls.ar-ae.json - Added multiple localized strings for user prompts and instructions related to model selection and question input.
package.nls.ar-eg.json - Similar additions as package.nls.ar-ae.json with localized strings for user interactions.
package.nls.ar-sa.json - Added localized strings for user prompts and instructions.
package.nls.bn-bd.json - Added new keys for user interactions and corrected existing entries.
package.nls.de.json - Introduced new strings for user prompts and updated existing entries for clarity.
package.nls.es.json - Added new localized strings and updated existing keys for better user guidance.
package.nls.fr.json - Enhanced user interface with new localized strings for interaction.
package.nls.hi-in.json - Added new keys for user prompts and instructions in Hindi.
package.nls.id-id.json - Introduced new entries for user prompts and updated existing keys.
package.nls.it.json - Added new strings for user guidance and updated existing entries.
package.nls.ja.json - Enhanced localization with new prompts and instructions.
package.nls.json - Added multiple new entries for user interactions and updated existing keys.
package.nls.kr.json - Introduced new strings for user prompts and instructions.
package.nls.ms-my.json - Added new entries for user interactions and updated existing keys.
package.nls.nl.json - Enhanced localization with new user prompts and updated existing entries.
package.nls.pl.json - Added new strings for user prompts and instructions.
package.nls.pt.json - Introduced new entries for better user guidance and updated existing keys.
package.nls.ru.json - Enhanced localization with new user prompts and updated existing entries.
package.nls.th-th.json - Added new strings for user prompts and instructions.
package.nls.tl-ph.json - Introduced new entries for user interactions and updated existing strings.
package.nls.tr.json - Enhanced user interface text with new prompts and updated existing entries.
package.nls.uk.json - Added new strings for user prompts and instructions.
package.nls.ur-pk.json - Introduced new entries for user prompts and updated existing keys.
package.nls.vi-vn.json - Added new strings for user prompts and instructions.
package.nls.zh-cn.json - Enhanced localization with new keys and modified existing keys for clarity.
package.nls.zh-tw.json - Introduced new entries for user prompts and updated existing keys.
src/renderer/components/IntroductionSplash.tsx - Removed commented-out code related to translation files, now displaying static text directly.
src/renderer/components/ModelSelect.tsx - Replaced hardcoded strings with localized strings for model selection messages.
src/renderer/components/MoreActionsMenu.tsx - Updated menu item texts to use translation keys for localization.
src/renderer/components/QuestionInputField.tsx - Updated placeholder and button labels to use translation keys instead of hardcoded strings.
src/renderer/layout.tsx - Removed debug state variable and refined API key handling logic.

Possibly related PRs

  • Add many i18n locale translated by gpt-4o, cc #77 #126: This PR adds multiple localization files, including package.nls.ar-ae.json, package.nls.ar-eg.json, and others, which directly relate to the localization changes made in the main PR's package.json, enhancing internationalization support for the project.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 12

🧹 Outside diff range and nitpick comments (22)
src/renderer/components/MoreActionsMenu.tsx (1)

194-194: LGTM with a minor suggestion.

Good job internationalizing the "View" text. Consider using a more descriptive fallback, e.g., "View Options".

-{t?.questionInputField?.view ?? "View"}
+{t?.questionInputField?.view ?? "View Options"}
package.nls.zh-tw.json (1)

130-130: Consider expanding 'LLM' abbreviation.

The translation uses the English abbreviation "LLM". Consider expanding it for clarity:

-  "questionInputField.changeLLM": "更改 LLM",
+  "questionInputField.changeLLM": "更改語言模型 (LLM)",
package.nls.zh-cn.json (2)

43-67: Prompt-related strings: Good, with a suggestion

Comprehensive coverage of coding tasks with clear descriptions. Consider adding examples for custom prompts to guide users.


81-157: UI-related strings: Excellent, with a suggestion

Comprehensive coverage of UI elements and actions. Clear and user-friendly.

Consider adding a brief description for the "Debug" action (line 113) to clarify its purpose for users.

package.nls.kr.json (1)

156-157: New view container name: Good, but could be improved

The addition of "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name" is good. However, consider using a more descriptive Korean translation for "Chat" to enhance clarity for Korean users.

Consider changing:

-  "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name": "Chat"
+  "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name": "채팅"
package.nls.ja.json (3)

104-104: New entries enhance user guidance. Consider adding ellipsis.

The new entries for question input and model selection improve user interaction. For "modelSelect.fetchingModels", consider adding an ellipsis to indicate an ongoing process:

-  "modelSelect.fetchingModels": "モデルを取得中...",
+  "modelSelect.fetchingModels": "モデルを取得中…",

This uses the proper Japanese ellipsis character.

Also applies to: 109-109, 141-142


130-133: Verbosity settings expanded. Clarify 'LLM' term.

The additions enhance user control over AI responses. However, "LLM" in "questionInputField.changeLLM" might be unfamiliar to some users. Consider:

-  "questionInputField.changeLLM": "AI の応答の詳細度を変更",
+  "questionInputField.changeAIResponseDetail": "AI の応答の詳細度を変更",

This maintains consistency with "verbosity.parentTooltip".

Also applies to: 155-155


156-156: View container name added. Consider more descriptive name.

The new entry for the view container name is good. However, "Chat" might be too generic. Consider:

-  "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name": "Chat"
+  "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name": "AI アシスタント"

This provides more context about the extension's functionality.

package.nls.json (2)

104-104: Fix ellipsis in prompt text

Correct the ellipsis to use three dots for consistency.

-  "questionInputField.askAQuestion": "Ask a question..",
+  "questionInputField.askAQuestion": "Ask a question...",

Missing Translations for questionInputField.selectAModelFirst in Localization Files

The key questionInputField.selectAModelFirst is missing translations (null values) in all localization files. Please update each package.nls.*.json file with the appropriate translations to ensure consistency across all supported languages.

  • Affected key: questionInputField.selectAModelFirst
🔗 Analysis chain

Line range hint 1-156: Overall: Good additions to localization

The new entries enhance the user experience by providing clear prompts and feedback. Minor issues were identified and addressed. Ensure these changes are reflected in other language files for consistency across localizations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify that new entries are present in other language files
for file in package.nls.*.json; do
  echo "Checking $file"
  jq '.["questionInputField.askAQuestion", "questionInputField.selectAModelFirst", "questionInputField.changeLLM", "questionInputField.actions", "questionInputField.markdown", "questionInputField.view", "modelSelect.noModelSelected", "modelSelect.fetchingModels"]' "$file"
done

Length of output: 12949

package.nls.pl.json (2)

130-130: Consider expanding LLM for clarity.

The translation is correct, but "LLM" might not be familiar to all Polish users.

Consider expanding or explaining LLM:

-  "questionInputField.changeLLM": "Zmień LLM",
+  "questionInputField.changeLLM": "Zmień model językowy (LLM)",

156-156: Consider using Polish equivalent for "Chat".

For consistency with the localized UI, consider using the Polish word.

Suggested change:

-  "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name": "Chat"
+  "chatgpt-reborn.contributes.views.vscode-chatgpt-view-container.name": "Czat"
package.nls.ur-pk.json (1)

155-157: Consider translating "Chat" to Urdu.

The new entry for chat view container name is good, but the value "Chat" is in English. Consider translating it to Urdu for consistency with the rest of the file.

package.nls.id-id.json (1)

109-109: Approve translation, but flag key structure.

Translation is correct. However, the key "questionInputField?.selectAModelFirst" contains a question mark, which is non-standard. Consider removing it for consistency.

package.nls.ms-my.json (1)

156-157: Consider localizing "Chat" if appropriate.

The translation "Chat" is correct, but consider using a more localized Malay term if one exists and is commonly used.

package.nls.nl.json (2)

109-109: LGTM: Accurate translation.

Note: The key contains a "?", which might be related to optional chaining in TypeScript. Ensure this is intentional in the code using this key.


140-141: LGTM: Accurate translations for model selection and verbosity tooltip.

All translations are correct. For consistency, consider using "Selecteer" instead of "Verander" in the verbosity tooltip, as it's used in other parts of the UI.

Also applies to: 154-154

package.nls.es.json (1)

109-109: Consistency check: Model selection prompt

The translation "Selecciona un modelo primero" is accurate. Consider using "Primero selecciona un modelo" for a more natural word order in Spanish.

src/renderer/components/QuestionInputField.tsx (2)

194-197: Good localization, consider destructuring.

The placeholder now uses a localized string, improving i18n support. Nice!

Consider destructuring t.questionInputField at the component's start for cleaner usage:

const { askAQuestion = "Ask a question..." } = t?.questionInputField ?? {};

Then use askAQuestion directly in the placeholder.


289-290: Localization improved, ensure consistency.

Good job localizing the button label. For consistency with the previous change:

Consider using the null coalescing operator:

t?.questionInputField?.selectAModelFirst ?? "Select a model first"
package.json (1)

Line range hint 430-441: New custom prompt configuration added

The addition of customPrompt6 is consistent with existing custom prompts. Consider updating the documentation to reflect this new option.

src/renderer/components/ModelSelect.tsx (1)

373-374: Localization implemented correctly.

Good job on implementing localization for these strings. For consistency, consider using optional chaining for t.modelSelect as well.

-            ? t?.modelSelect?.noModelSelected ?? "No model selected"
-            : t?.modelSelect?.fetchingModels ?? "Fetching models.."}
+            ? t?.modelSelect?.noModelSelected ?? "No model selected"
+            : t?.modelSelect?.fetchingModels ?? "Fetching models..."}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between af6e61f and 92ec70e.

📒 Files selected for processing (32)
  • package.json (2 hunks)
  • package.nls.ar-ae.json (3 hunks)
  • package.nls.ar-eg.json (3 hunks)
  • package.nls.ar-sa.json (3 hunks)
  • package.nls.bn-bd.json (3 hunks)
  • package.nls.de.json (3 hunks)
  • package.nls.es.json (3 hunks)
  • package.nls.fr.json (3 hunks)
  • package.nls.hi-in.json (3 hunks)
  • package.nls.id-id.json (3 hunks)
  • package.nls.it.json (3 hunks)
  • package.nls.ja.json (3 hunks)
  • package.nls.json (3 hunks)
  • package.nls.kr.json (3 hunks)
  • package.nls.ms-my.json (3 hunks)
  • package.nls.nl.json (3 hunks)
  • package.nls.pl.json (3 hunks)
  • package.nls.pt.json (3 hunks)
  • package.nls.ru.json (3 hunks)
  • package.nls.th-th.json (3 hunks)
  • package.nls.tl-ph.json (3 hunks)
  • package.nls.tr.json (3 hunks)
  • package.nls.uk.json (3 hunks)
  • package.nls.ur-pk.json (3 hunks)
  • package.nls.vi-vn.json (3 hunks)
  • package.nls.zh-cn.json (1 hunks)
  • package.nls.zh-tw.json (3 hunks)
  • src/renderer/components/IntroductionSplash.tsx (0 hunks)
  • src/renderer/components/ModelSelect.tsx (1 hunks)
  • src/renderer/components/MoreActionsMenu.tsx (3 hunks)
  • src/renderer/components/QuestionInputField.tsx (2 hunks)
  • src/renderer/layout.tsx (0 hunks)
💤 Files with no reviewable changes (2)
  • src/renderer/components/IntroductionSplash.tsx
  • src/renderer/layout.tsx
🧰 Additional context used
📓 Path-based instructions (26)
package.nls.ar-ae.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.ar-eg.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.ar-sa.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.bn-bd.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.de.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.es.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.fr.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.hi-in.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.id-id.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.it.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.ja.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.kr.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.ms-my.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.nl.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.pl.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.pt.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.ru.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.th-th.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.tl-ph.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.tr.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.uk.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.ur-pk.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.vi-vn.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.zh-cn.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

package.nls.zh-tw.json (1)

Pattern package.nls*.json: package.nls files are VS Code extension translation files.

At the moment, the full list of translation files is:
package.nls.de.json
package.nls.es.json
package.nls.fr.json
package.nls.it.json
package.nls.ja.json
package.nls.json
package.nls.kr.json
package.nls.nl.json
package.nls.pl.json
package.nls.pt.json
package.nls.tr.json
package.nls.uk.json
package.nls.zh-cn.json
package.nls.zh-tw.json

🔇 Additional comments (123)
src/renderer/components/MoreActionsMenu.tsx (2)

90-90: LGTM: Improved i18n support.

Good job on internationalizing the "Change LLM" text.


106-106: LGTM: Internationalized "Actions" text.

Nice work on adding i18n support for the "Actions" link.

package.nls.zh-tw.json (2)

104-104: Translation accurate and concise.


131-133: Translations accurate and consistent.

package.nls.zh-cn.json (3)

2-23: API key setup strings: Approved

Clear instructions and important cost information added. Good job on user guidance.


24-42: Chat functionality strings: LGTM

Comprehensive coverage of AI-assisted coding tasks. Concise and clear.


68-80: Configuration strings: Approved

Well-explained API settings and model descriptions. Users will find this helpful.

package.nls.kr.json (4)

104-108: New question input field entries: LGTM

The added entries for the question input field enhance user interaction. They're concise and clear.

Also applies to: 130-133


141-142: Model selection entries: Good addition

The new entries for model selection provide clear feedback to users during the selection process.


155-155: Updated verbosity tooltip: Approved

The update to "verbosity.parentTooltip" maintains consistency with user guidance improvements.


Line range hint 1-157: Overall: Good localization updates

The changes to package.nls.kr.json effectively enhance the Korean localization, particularly for new features like model selection and question input. The translations are concise and clear, improving the user experience for Korean users.

package.nls.ja.json (1)

Line range hint 1-157: Overall consistency maintained.

The new and modified entries maintain consistency with the existing localization style and conventions. Good job on keeping the translations clear and concise.

package.nls.ar-eg.json (4)

104-108: LGTM: New entry for question input placeholder.

The Arabic translation for "Ask a question..." is appropriate and consistent with the key.


Line range hint 109-129: LGTM: New entries for UI elements and actions.

The Arabic translations for various UI elements and actions are appropriate and consistent with their respective keys. These additions enhance the localization of the extension.


130-133: LGTM: New entries for LLM change and UI actions.

The Arabic translations for changing LLM, actions, markdown formatting, and view options are appropriate and consistent with their respective keys.


141-142: LGTM: New entries for model selection states.

The Arabic translations for "No model selected" and "Fetching models..." are appropriate and consistent with their respective keys.

package.nls.ar-ae.json (5)

104-109: New entries for question input field look good.

The translations are accurate and consistent with the described functionality.


130-133: New entries for model selection are correctly translated.

The translations accurately reflect the intended functionality for changing LLM, actions, formatting, view, and model selection states.

Also applies to: 141-142


155-155: Updated verbosity tooltip translation is accurate.

The modified translation correctly describes the functionality of changing AI response detail level.


156-157: New entry for chat view container is correctly translated.

The translation accurately reflects the name of the chat view container.


Line range hint 1-157: Overall, the Arabic localization file is well-maintained and accurate.

All new entries and modifications are consistent with the intended functionality. The translations are clear and appropriate for the Arabic (UAE) locale.

package.nls.th-th.json (2)

Line range hint 104-133: New question input field strings look good.

The added translations for the question input field and related actions are accurate and consistent. They maintain a good balance between being concise and informative.


141-142: Model selection strings are well-translated.

The new strings for model selection UI elements are accurately translated and maintain consistency with the existing style.

package.nls.ar-sa.json (5)

104-104: New entry for question input placeholder

The translation "اسأل سؤالًا..." (Ask a question...) is concise and appropriate.


109-109: New entry for model selection prompt

The translation "حدد نموذجًا أولاً" (Select a model first) is clear and concise.


130-133: New entries for question input actions

The translations for "Change LLM", "Actions", "Format", and "View" are concise and appropriate.


141-142: New entries for model selection states

The translations for "No model selected" and "Fetching models..." are clear and consistent with the UI context.


155-157: Updated verbosity tooltip and view container name

The translations for the verbosity tooltip and view container name are consistent with existing entries.

package.nls.json (2)

130-133: LGTM: New question input field actions

These new entries provide clear, concise labels for UI actions. They're consistent with the existing style.


141-142: LGTM: New model selection status messages

These new entries provide clear feedback for the model selection process. They're consistent with the existing style and use correct punctuation.

package.nls.vi-vn.json (5)

104-104: New entry looks good.

The translation for "Ask a question" is accurate and concise.


130-130: New entry is correct.

The translation for "Change LLM" is accurate and concise.


141-142: New model select entries are correct.

The translations for "No model selected" and "Fetching models..." are accurate and concise.


155-157: Modified and new entries look good.

The translation for "Change AI response verbosity" is accurate. The new entry for "Chat" is also correct and concise.


109-109: ⚠️ Potential issue

Key name contains unexpected character.

The translation is correct, but the key name "questionInputField?.selectAModelFirst" contains an unexpected ?. This might cause issues when accessing the value.

Consider removing the ? from the key name:

-  "questionInputField?.selectAModelFirst": "Hãy chọn một mô hình trước",
+  "questionInputField.selectAModelFirst": "Hãy chọn một mô hình trước",

Likely invalid or redundant comment.

package.nls.pl.json (5)

104-104: LGTM: Accurate translation for "Ask a question".


131-133: LGTM: Accurate translations for UI elements.


141-142: LGTM: Accurate translations for model selection states.


155-155: LGTM: Accurate translation for verbosity tooltip.


Line range hint 1-157: Overall, translations are accurate and idiomatic.

A few minor improvements were suggested for clarity and consistency. Great job on the localization!

package.nls.ur-pk.json (4)

104-108: New translations for question input field look good.

The added translations for the question input field are consistent and appropriate.


109-109: Model selection prompt translation is correct.

The added translation for the model selection prompt is appropriate and consistent.


130-133: New translations for question input field actions are appropriate.

The added translations for the question input field actions are consistent and correct.


141-142: Model selection state translations look good.

The added translations for model selection states are appropriate and consistent.

package.nls.tr.json (5)

104-104: New UI strings look good.

The added translations for question input field elements are accurate and consistent.

Also applies to: 109-109, 130-133


141-142: Model selection strings are well-translated.

The new strings for model selection accurately convey the intended meanings in Turkish.


155-155: Updated verbosity tooltip translation is accurate.

The modified string correctly conveys the new meaning of changing the AI's response detail level.


156-157: View container name translation is correct.

The new string "Chat" is appropriately translated to Turkish.


Line range hint 1-157: Overall, excellent localization updates.

The new translations and modifications maintain consistency and accuracy throughout the file. They effectively enhance the Turkish localization of the VS Code extension.

package.nls.id-id.json (9)

104-104: LGTM: New entry for question input field.

The translation "Tanyakan pertanyaan" accurately conveys "Ask a question".


130-130: LGTM: New entry for changing LLM.

The translation "Ubah LLM" correctly conveys "Change LLM".


131-131: LGTM: New entry for actions.

The translation "Tindakan" accurately represents "Actions".


132-132: LGTM: New entry for Markdown.

Keeping "Markdown" untranslated is correct as it's a technical term.


133-133: LGTM: New entry for view.

The translation "Lihat" correctly conveys "View".


141-141: LGTM: New entry for no model selected.

The translation "Tidak ada model yang dipilih" accurately represents "No model selected".


142-142: LGTM: New entry for fetching models.

The translation "Mengambil model..." correctly conveys "Fetching models..." including the ellipsis.


155-155: LGTM: Updated entry for verbosity tooltip.

The translation "Ubah tingkat detail respons AI" accurately represents "Change AI response verbosity level".


156-156: LGTM: New entry for chat view container name.

Keeping "Chat" untranslated is correct as it's commonly used in Indonesian.

package.nls.uk.json (5)

104-108: New entries for question input field: LGTM

These additions enhance the UI localization for the chat interface.


109-109: New entry for model selection prompt: Approved

Clear and concise instruction for users.


130-133: New entries for UI actions: Good to go

These additions improve the localization coverage for UI elements.


141-142: New entries for model selection states: Approved

These additions provide clear user feedback during model selection.


155-156: Updated verbosity tooltip and new chat view entry: LGTM

These changes improve consistency and extend localization coverage.

package.nls.ms-my.json (5)

104-108: New translations for question input field look good.

The added translations are accurate and consistent with the existing style.


109-109: Model selection prompt translation is correct.

The added translation accurately conveys the message to select a model first.


130-133: Additional question input field action translations are accurate.

The new translations for changing LLM, actions, markdown, and view are correct and consistent.


141-142: Model selection status translations are correct.

The added translations for no model selected and fetching models status are accurate and consistent.


Line range hint 1-157: Overall, translations are accurate and consistent.

The new entries have been successfully added and translated. The file maintains consistency with existing translations and accurately reflects the English versions. Consider localizing "Chat" if a more appropriate Malay term exists.

package.nls.pt.json (6)

104-104: LGTM: Accurate translation for question prompt.


109-109: Translation accurate, but key format unusual.

The translation is correct, but the "?" in the key questionInputField? is atypical for JSON. Confirm if this is intentional or a typo.


130-133: LGTM: Consistent and accurate translations for UI actions.

Translations are concise and maintain technical terms appropriately.


141-142: LGTM: Clear translations for model selection states.

Translations accurately convey the model selection process.


156-156: LGTM: Appropriate label for chat container.

"Chat" is kept untranslated, which is suitable for this context.


Line range hint 1-157: Overall: High-quality Portuguese translations added.

The new entries provide accurate and consistent translations for the UI. The only point of concern is the unusual key format in questionInputField?. Ensure this is intentional.

package.nls.hi-in.json (6)

104-105: New key added for question input placeholder

The translation for "Ask a question..." looks correct and natural in Hindi.


109-110: New key added for model selection prompt

The translation for "Select a model first" is accurate and concise.


130-133: New keys added for question input actions

The translations for "Change LLM", "Actions", "Markdown", and "View" are correct and concise.


141-142: New keys added for model selection states

The translations for "No model selected" and "Loading models..." are accurate and natural in Hindi.


155-156: New key added for verbosity tooltip

The translation for "Change the clarity of AI responses" is correct and clear in Hindi.


156-157: New key added for chat view container

The translation for "Chat" is simple and accurate.

package.nls.ru.json (4)

104-104: New translation added correctly.

The Russian translation for "Ask a question" is accurate and concise.


130-130: New translation added correctly.

The Russian translation for "Change LLM" is accurate and concise.


131-133: New translations added correctly.

The Russian translations for "Actions", "Markdown", and "View" are accurate and concise.


155-155: Translation updated correctly.

The Russian translation for the verbosity parent tooltip is accurate and clear.

package.nls.bn-bd.json (4)

104-108: LGTM: New question input field translations.

The added translations for the question input field are accurate and consistent.


109-109: LGTM: Model selection prompt translation.

The added translation for the model selection prompt is accurate.


130-133: LGTM: Question input field action translations.

The added translations for question input field actions are accurate and consistent.


157-159: LGTM: Verbosity tooltip and view container translations.

The added translations for the verbosity tooltip and view container name are accurate and consistent.

package.nls.nl.json (5)

104-104: LGTM: Clear and concise translation.


129-130: LGTM: Concise and accurate translations.

Both "Verander LLM" and "Acties" are appropriate Dutch translations for their respective English terms.


131-132: LGTM: Correct translations for technical and UI terms.

"Markdown" is appropriately left untranslated, and "Bekijk" is the correct Dutch translation for "View".


155-155: LGTM: Appropriate use of "Chat" for Dutch UI.

Keeping "Chat" untranslated is correct, as it's commonly used in Dutch interfaces.


Line range hint 1-156: Overall: High-quality Dutch translations added.

The new translations are accurate and appropriate for the ChatGPT Reborn extension's UI. Minor suggestions for consistency have been made, but overall, the localization work is commendable.

package.nls.es.json (5)

104-104: Translation accuracy: Approved

The translation "Haz una pregunta" for "Ask a question" is accurate and natural in Spanish.


110-110: Translation update: Approved

The change from "Usar selección del editor" to "Selección del editor" is appropriate, making the text more concise.


141-142: Model selection messages: Approved

The translations for model selection messages are accurate and consistent with the extension's context.


155-155: Tooltip update: Approved

The updated tooltip translation "Cambiar la verbosidad de las respuestas de la IA" is accurate and clear.


156-157: New entry: Chat view container

The translation "Chat" for the view container name is correct. Ensure this matches the actual view name in the extension's TypeScript code.

#!/bin/bash
# Verify if the view container name is used consistently
rg -i "vscode-chatgpt-view-container" --type ts
package.nls.fr.json (5)

104-105: LGTM: New translation added

The translation for "askAQuestion" is accurate and concise.


130-133: New translations added correctly

The translations for new question input field actions are accurate and maintain consistency. Good job keeping "LLM" as is.


141-142: Model selection translations added

The new translations for model selection states are accurate and contextually appropriate.


155-157: Tooltip updated, view name added

The verbosity tooltip update and the new view container name translation are both accurate and concise.


Line range hint 1-157: Overall: Good additions to French localization

The new translations and updates improve the French localization, covering new features like question input and model selection. All translations are accurate and consistent. Just double-check the key name with "?" on line 109.

package.nls.tl-ph.json (4)

Line range hint 104-133: New question input field translations look good.

The added translations for the question input field are consistent and appropriate. They cover various actions and labels, enhancing the user experience for Tagalog speakers.


141-142: Model selection translations are accurate.

The new translations for model selection status messages are correct and consistent with the English versions.


155-155: Updated verbosity tooltip translation is correct.

The modified translation for the verbosity tooltip is accurate and maintains consistency with other UI elements.


156-157: Chat view container translation added. Overall, translations are complete and consistent.

The new translation for the chat view container name is appropriate. All new and updated translations in this file are accurate and consistent with the English versions, enhancing the localization for Tagalog-speaking users.

package.nls.it.json (6)

104-108: New entries for question input field look good.

Translations are accurate and consistent. No issues found.


109-109: Model selection prompt translation is correct.

The Italian translation accurately conveys the message to select a model first.


130-133: Additional question input field actions are well translated.

The Italian translations for changing LLM, actions, markdown, and view options are accurate and concise.


141-142: Model selection state translations are correct.

The Italian translations for "No model selected" and "Fetching models" states are accurate.


155-156: Verbosity tooltip and chat view container name are well translated.

The updated verbosity parent tooltip and new chat view container name are accurately translated to Italian.


Line range hint 1-157: Overall, the Italian translations are accurate and complete.

All new entries and updates in this localization file are well-translated and consistent with the English versions. The changes effectively support the new UI elements and functionality introduced in this PR.

package.nls.de.json (7)

105-105: New entry looks good.

The translation for "Ask a question" is accurate and concise.


131-131: New entry looks good.

The translation for "Change LLM" is accurate and concise.


132-132: New entry looks good.

The translation for "Actions" is accurate and concise.


133-133: New entry looks good.

Keeping "Markdown" untranslated is the correct approach for technical terms.


134-134: New entry looks good.

The translation for "View" is accurate and concise.


156-156: Updated entry looks good.

The translation for "Change the verbosity of AI responses" is accurate and clear.


157-157: New entry for view container name looks good.

The translation for "Chat" is accurate and consistent with the extension's purpose.

src/renderer/components/QuestionInputField.tsx (1)

Line range hint 1-500: Comprehensive localization effort.

The localization changes throughout the component are consistent and well-implemented. Good job on improving the i18n support across the QuestionInputField component.

package.json (2)

281-281: Localization improvement for view name

Good job on internationalizing the view name. This enhances the extension's accessibility for non-English users.


Line range hint 177-180: New command for custom prompt 6

The new command for customPrompt6 is correctly implemented. Ensure that the corresponding functionality is implemented in the extension's code.

package.nls.zh-tw.json Outdated Show resolved Hide resolved
package.nls.zh-tw.json Outdated Show resolved Hide resolved
package.nls.ar-eg.json Outdated Show resolved Hide resolved
package.nls.th-th.json Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
package.nls.ru.json Outdated Show resolved Hide resolved
package.nls.bn-bd.json Outdated Show resolved Hide resolved
package.nls.es.json Show resolved Hide resolved
package.nls.fr.json Outdated Show resolved Hide resolved
package.nls.de.json Outdated Show resolved Hide resolved
Christopher-Hayes and others added 11 commits October 20, 2024 10:03
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Christopher-Hayes Christopher-Hayes added this to the 3.26.0 milestone Oct 20, 2024
@Christopher-Hayes Christopher-Hayes merged commit 65e5c20 into develop Oct 20, 2024
1 check passed
@Christopher-Hayes Christopher-Hayes deleted the 76-incomplete-translations-for-new-ui-elements branch October 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incomplete Translations for New UI Elements
1 participant