Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: telesales for PII accounts #662

Closed
wants to merge 1 commit into from

Conversation

beatrizmaselli
Copy link
Contributor

What problem is this solving?

Telesales feature not working for PII accounts.

This endpoint is not public for PII accounts:

curl --location 'https://dunnesstoresqa.vtexcommercestable.com.br/api/checkout/pub/orderForm/ef55388eedd04d6da04e42dd05251570' \
--header 'Accept: application/json' \
--header 'Content-Type: application/json' \
--header 'Cookie: CheckoutOrderFormOwnership=; checkout.vtex.com=__ofid=ef55388eedd04d6da04e42dd05251570' \
--data '{
    "expectedOrderFormSections": [
        "items"
    ]
}'

I need to double check with the checkout team but the error returned is:

{
    "fields": {},
    "error": {
        "code": "001",
        "message": "The key \"schema\" was not found in the response",
        "exception": null
    },
    "operationId": "917e31e9-a252-4dc8-82cb-c3611fd16706"
}

How to test it?

  1. Enter a PII account
  2. Add the telesales toolbar
  3. Add a telesales role to your user
  4. Call the store-graphql for impersonification
  5. With the previous version the return is 500 and with the current version is 200

Workspace

Only this PR do not solve the telesales problem since the profile was not completed by the session. It was needed to develop an extra App in order to do so.

Related to / Depends on

Only this PR do not solve the telesales problem since the profile was not completed by the session. It was needed to develop an extra App in order to do so but that is a private app.

Uploading Screen Recording 2024-05-17 at 23.22.38.mov…

@beatrizmaselli beatrizmaselli requested a review from a team as a code owner May 17, 2024 21:39
@beatrizmaselli beatrizmaselli requested review from lariciamota, RodrigoTadeuF and ArthurTriis1 and removed request for a team May 17, 2024 21:39
Copy link
Contributor

vtex-io-ci-cd bot commented May 17, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 17, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@beatrizmaselli
Copy link
Contributor Author

This is not needed so I am closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant