check user email with toLowerCase #666
Conversation
wagnerlduarte
requested review from
gabpaladino,
hellofanny and
emersonlaurentino
and removed request for
a team
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
| @@ -260,7 +260,8 @@ async function checkUserAccount( | |||
| 'id' in tokenUser && | |||
| !( | |||
| tokenUser.account === account && | |||
| (isUserCallCenterOperator || tokenUser.user === currentProfile?.email) | |||
| (isUserCallCenterOperator || | |||
| tokenUser.id.toLowerCase() === currentProfile?.userId.toLowerCase()) | |||
There was a problem hiding this comment.
não vale a pena usar o email nesse primeiro momento? e depois a gente ver com os logs se o match do id vai ser sempre certo
There was a problem hiding this comment.
Lucas, muito bem observado, não havia me dado conta.
Fiz a alteração para seguirmos validando por email. ✅
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Check user email with toLowerCase to prevent error when the identity user has difference from token
https://vtex-dev.atlassian.net/browse/OMS-6340
How to test it?
https://profile--dunnesstorespreprod.myvtex.com/account#/profile
User: [email protected]
Password: Dunnes123
Workspace