-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return an empty array to the deprecated checkout endpoint #668
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
CHANGELOG.md
Outdated
|
||
|
||
[Unreleased]: https://github.com/vtex-apps/store-graphql/compare/v2.171.1-beta...HEAD | ||
[2.171.1-beta]: https://github.com/vtex-apps/store-graphql/compare/v2.171.0...v2.171.1-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, we don't need to add beta and unreleased tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, removed.
Co-authored-by: Iago Espinoza <[email protected]>
Co-authored-by: Iago Espinoza <[email protected]>
…ps/store-graphql into feat/resolve-deprecated-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Checkout is deprecating the
orders
endpoint. To avoid throwing an error forstore-graphql
users, this PR catches the HTTP 405 error code thrown by Checkout and returns an empty array in the query.How to test it?
[email protected]*
Screenshots or example usage:
[Before]
[After]
Related to / Depends on
PR do Checkout
How does this PR make you feel? 🔗