Change props spreading pattern from ...rest to ...otherProps on T…

…able components
vtex · Oct 18, 2021 · 35a85ac · 35a85ac
1 parent 6a26200
commit 35a85ac
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 12 deletions.
diff --git a/packages/store-ui/src/molecules/Table/Table.tsx b/packages/store-ui/src/molecules/Table/Table.tsx
@@ -10,11 +10,11 @@ export interface TableProps extends HTMLAttributes<HTMLTableElement> {
 }
 
 const Table = forwardRef<HTMLTableElement, TableProps>(function Table(
-  { testId = 'store-table', children, ...rest },
+  { testId = 'store-table', children, ...otherProps },
   ref
 ) {
   return (
-    <table ref={ref} data-store-table data-testid={testId} {...rest}>
+    <table ref={ref} data-store-table data-testid={testId} {...otherProps}>
       {children}
     </table>
   )

diff --git a/packages/store-ui/src/molecules/Table/TableBody.tsx b/packages/store-ui/src/molecules/Table/TableBody.tsx
@@ -11,9 +11,17 @@ export interface TableBodyProps
 }
 
 const TableBody = forwardRef<HTMLTableSectionElement, TableBodyProps>(
-  function TableBody({ children, testId = 'store-table-body', ...rest }, ref) {
+  function TableBody(
+    { children, testId = 'store-table-body', ...otherProps },
+    ref
+  ) {
     return (
-      <tbody ref={ref} data-testid={testId} data-store-table-body {...rest}>
+      <tbody
+        ref={ref}
+        data-testid={testId}
+        data-store-table-body
+        {...otherProps}
+      >
         {children}
       </tbody>
     )

diff --git a/packages/store-ui/src/molecules/Table/TableCell.tsx b/packages/store-ui/src/molecules/Table/TableCell.tsx
@@ -21,7 +21,13 @@ export interface TableCellProps extends HTMLAttributes<HTMLTableCellElement> {
 
 const TableCell = forwardRef<HTMLTableCellElement, TableCellProps>(
   function TableCell(
-    { testId = 'store-table-cell', children, variant = 'data', scope, ...rest },
+    {
+      testId = 'store-table-cell',
+      children,
+      variant = 'data',
+      scope,
+      ...otherProps
+    },
     ref
   ) {
     const Cell = variant === 'header' ? 'th' : 'td'
@@ -32,7 +38,7 @@ const TableCell = forwardRef<HTMLTableCellElement, TableCellProps>(
         data-store-table-cell={variant}
         data-testid={testId}
         scope={scope}
-        {...rest}
+        {...otherProps}
       >
         {children}
       </Cell>

diff --git a/packages/store-ui/src/molecules/Table/TableFooter.tsx b/packages/store-ui/src/molecules/Table/TableFooter.tsx
@@ -12,11 +12,16 @@ export interface TableFooterProps
 
 const TableFooter = forwardRef<HTMLTableSectionElement, TableFooterProps>(
   function TableFooter(
-    { children, testId = 'store-table-footer', ...rest },
+    { children, testId = 'store-table-footer', ...otherProps },
     ref
   ) {
     return (
-      <tfoot ref={ref} data-testid={testId} data-store-table-footer {...rest}>
+      <tfoot
+        ref={ref}
+        data-testid={testId}
+        data-store-table-footer
+        {...otherProps}
+      >
         {children}
       </tfoot>
     )

diff --git a/packages/store-ui/src/molecules/Table/TableHead.tsx b/packages/store-ui/src/molecules/Table/TableHead.tsx
@@ -11,9 +11,17 @@ export interface TableHeadProps
 }
 
 const TableHead = forwardRef<HTMLTableSectionElement, TableHeadProps>(
-  function TableHead({ children, testId = 'store-table-head', ...rest }, ref) {
+  function TableHead(
+    { children, testId = 'store-table-head', ...otherProps },
+    ref
+  ) {
     return (
-      <thead ref={ref} data-testid={testId} data-store-table-head {...rest}>
+      <thead
+        ref={ref}
+        data-testid={testId}
+        data-store-table-head
+        {...otherProps}
+      >
         {children}
       </thead>
     )

diff --git a/packages/store-ui/src/molecules/Table/TableRow.tsx b/packages/store-ui/src/molecules/Table/TableRow.tsx
@@ -10,9 +10,12 @@ export interface TableRowProps extends HTMLAttributes<HTMLTableRowElement> {
 }
 
 const TableRow = forwardRef<HTMLTableRowElement, TableRowProps>(
-  function TableRow({ testId = 'store-table-row', children, ...rest }, ref) {
+  function TableRow(
+    { testId = 'store-table-row', children, ...otherProps },
+    ref
+  ) {
     return (
-      <tr ref={ref} data-store-table-row data-testid={testId} {...rest}>
+      <tr ref={ref} data-store-table-row data-testid={testId} {...otherProps}>
         {children}
       </tr>
     )