Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR updates our icon library to fit the new VTEX Design Foundation.
Activities
Rating
componentFS Core
store icons Chore: Replace icons props #2292For the Future
How it works?
For now, we're going to accept both symbol styles, but all new symbols added by us will be following the new pattern and the old will be deprecated eventually. Some important changes on the
Icon
component:size
prop24
height
,width
andweight
props are now marked as deprecated (but it's still working)How to test it?
Our old doc is updated for testing and reviewing purposes: https://faststore-site-git-feat-new-icons-faststore.vercel.app/docs/icons