Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured augmentations #157

Merged
merged 12 commits into from
Oct 10, 2021
Merged

Restructured augmentations #157

merged 12 commits into from
Oct 10, 2021

Conversation

DonkeyShot21
Copy link
Collaborator

No description provided.

@@ -21,6 +21,8 @@ python3 ../../../main_pretrain.py \
--hue 0.1 \
--gaussian_prob 0.0 0.0 \
--solarization_prob 0.0 0.2 \
--crop_size 32 \
--num_crops_per_pipeline 1 1 \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change name, pipeline is not really a good name because it collides with dali's naming

@@ -38,3 +38,46 @@ python3 ../../../main_pretrain.py \
--pred_hidden_dim 8192 \
--base_tau_momentum 0.99 \
--final_tau_momentum 1.0

# multicrop byol
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a better way to handle this, duplicating all scripts is not a good solution

"label",
if unique_augs > 1:
transforms = [
transform_pipeline(device=dali_device, **kwargs,) for kwargs in transform_kwargs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change name

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #157 (2708042) into main (0a8e415) will decrease coverage by 10.53%.
The diff coverage is 66.87%.

Flag Coverage Δ *Carryforward flag
cpu 83.83% <78.70%> (+2.02%) ⬆️
dali 41.71% <34.73%> (ø) Carriedforward from b52366c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/methods/barlow_twins.py 100.00% <ø> (ø)
solo/methods/deepclusterv2.py 82.22% <ø> (-13.67%) ⬇️
solo/methods/dino.py 89.09% <ø> (ø)
solo/methods/mocov2plus.py 97.18% <ø> (ø)
solo/methods/nnbyol.py 65.71% <ø> (ø)
solo/methods/nnclr.py 100.00% <ø> (ø)
solo/methods/nnsiam.py 100.00% <ø> (ø)
solo/methods/ressl.py 97.01% <ø> (ø)
solo/methods/simsiam.py 100.00% <ø> (ø)
solo/methods/swav.py 100.00% <ø> (ø)
... and 24 more

@vturrisi vturrisi merged commit 39e6b4c into main Oct 10, 2021
@vturrisi vturrisi deleted the restructured_augmentations branch October 10, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants