Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans design of methods a bit #238

Merged
merged 12 commits into from
Apr 12, 2022
Merged

Cleans design of methods a bit #238

merged 12 commits into from
Apr 12, 2022

Conversation

vturrisi
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #238 (e5cdf44) into main (d5ac12d) will decrease coverage by 2.47%.
The diff coverage is 89.33%.

Flag Coverage Δ *Carryforward flag
cpu 83.43% <97.39%> (-0.14%) ⬇️
dali 39.15% <29.13%> (ø) Carriedforward from d5ac12d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/methods/dali.py 83.47% <40.00%> (-7.52%) ⬇️
solo/utils/whitening.py 78.98% <50.00%> (-13.77%) ⬇️
solo/methods/linear.py 89.36% <76.92%> (+1.18%) ⬆️
solo/methods/base.py 77.68% <77.14%> (+0.76%) ⬆️
solo/methods/simclr.py 54.54% <78.57%> (+2.78%) ⬆️
solo/methods/byol.py 75.86% <84.37%> (-20.57%) ⬇️
solo/methods/nnbyol.py 69.23% <91.66%> (-0.24%) ⬇️
solo/args/utils.py 89.88% <100.00%> (ø)
solo/methods/barlow_twins.py 100.00% <100.00%> (ø)
solo/methods/deepclusterv2.py 87.34% <100.00%> (-8.55%) ⬇️
... and 30 more

@DonkeyShot21 DonkeyShot21 merged commit 86c4867 into main Apr 12, 2022
@vturrisi vturrisi deleted the change_forward branch April 12, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants