Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ddp issue with simclr #259

Merged
merged 5 commits into from
Jun 12, 2022
Merged

Fix ddp issue with simclr #259

merged 5 commits into from
Jun 12, 2022

Conversation

vturrisi
Copy link
Owner

No description provided.

This was referenced Jun 12, 2022
Closed
Closed
@codecov
Copy link

codecov bot commented Jun 12, 2022 •
edited
Loading

Codecov Report

Merging #259 (154c7b0) into main (379df0c) will increase coverage by 0.39%.
The diff coverage is 18.18%.

Flag Coverage Δ *Carryforward flag
cpu 80.37% <25.00%> (-0.07%) ⬇️
dali 40.66% <0.00%> (ø) Carriedforward from 93d08b7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/methods/base.py 79.06% <0.00%> (+0.55%) ⬆️
solo/methods/simclr.py 100.00% <ø> (+22.38%) ⬆️
solo/utils/dali_dataloader.py 37.80% <0.00%> (-0.26%) ⬇️
solo/args/utils.py 67.33% <50.00%> (+3.69%) ⬆️

@vturrisi vturrisi merged commit 2b0eb2c into main Jun 12, 2022
@vturrisi vturrisi deleted the fix_simclr branch July 15, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonkeyShot21 DonkeyShot21 Awaiting requested review from DonkeyShot21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vturrisi