Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mocov3 #268

Merged
merged 14 commits into from
Jun 28, 2022
Merged

Add Mocov3 #268

merged 14 commits into from
Jun 28, 2022

Conversation

vturrisi
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #268 (5b79006) into main (fbbf663) will increase coverage by 0.02%.
The diff coverage is 93.75%.

Flag Coverage Δ *Carryforward flag
cpu 80.90% <93.75%> (+0.53%) ⬆️
dali 40.66% <80.00%> (ø) Carriedforward from 6f83cef

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/methods/byol.py 77.64% <ø> (-8.07%) ⬇️
solo/utils/backbones.py 67.05% <0.00%> (ø)
solo/losses/mocov3.py 80.95% <80.95%> (ø)
solo/losses/__init__.py 100.00% <100.00%> (ø)
solo/losses/mocov2plus.py 100.00% <100.00%> (ø)
solo/methods/__init__.py 92.85% <100.00%> (+0.85%) ⬆️
solo/methods/base.py 78.42% <100.00%> (-0.64%) ⬇️
solo/methods/mocov2plus.py 100.00% <100.00%> (ø)
solo/methods/mocov3.py 100.00% <100.00%> (ø)
solo/losses/moco.py 33.33% <0.00%> (-66.67%) ⬇️
... and 4 more

@DonkeyShot21
Copy link
Collaborator

Offline linear eval and cifar experiments are missing. MoCoV3 + link is missing under supported methods.

@DonkeyShot21
Copy link
Collaborator

isnt it better to unify the losses and just pass the labels (diagonal vs first column)?

@DonkeyShot21 DonkeyShot21 merged commit bbf2d7e into main Jun 28, 2022
@vturrisi vturrisi deleted the mocov3 branch June 28, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants