Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for H5 data, improved scripts and data handling #275

Merged
merged 41 commits into from
Jul 14, 2022
Merged

Conversation

vturrisi
Copy link
Owner

@vturrisi vturrisi commented Jul 8, 2022

No description provided.

@vturrisi
Copy link
Owner Author

vturrisi commented Jul 8, 2022

We are still missing the h5 file constructor, the rest is in place.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #275 (bbc2b46) into main (0273243) will decrease coverage by 1.06%.
The diff coverage is 42.03%.

Flag Coverage Δ *Carryforward flag
cpu 82.09% <45.71%> (-1.01%) ⬇️
dali 40.66% <11.76%> (ø) Carriedforward from 6de7de3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
solo/utils/__init__.py 83.33% <ø> (+2.08%) ⬆️
solo/utils/dali_dataloader.py 37.96% <0.00%> (+0.16%) ⬆️
solo/utils/h5_dataset.py 23.88% <23.88%> (ø)
solo/utils/pretrain_dataloader.py 58.79% <33.33%> (-1.80%) ⬇️
solo/utils/classification_dataloader.py 47.22% <41.66%> (-6.81%) ⬇️
solo/methods/base.py 78.40% <50.00%> (-0.32%) ⬇️
solo/utils/misc.py 68.18% <50.00%> (-1.89%) ⬇️
solo/args/dataset.py 76.19% <60.00%> (+1.19%) ⬆️
solo/methods/linear.py 88.83% <66.66%> (+0.37%) ⬆️
solo/args/utils.py 69.93% <80.00%> (+0.85%) ⬆️
... and 11 more

main_linear.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
main_pretrain.py Outdated
val_loader = None
else:
_, val_loader = prepare_data_classification(
args.dataset,
data_dir=args.data_dir,
train_dir=args.train_dir,
val_dir=args.val_dir,
train_h5_path=args.train_h5_path,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

solo/args/utils.py Show resolved Hide resolved
solo/args/utils.py Show resolved Hide resolved
solo/methods/linear.py Outdated Show resolved Hide resolved
solo/methods/mocov3.py Show resolved Hide resolved
solo/utils/convert_imgfolder_to_h5.py Outdated Show resolved Hide resolved
solo/utils/misc.py Outdated Show resolved Hide resolved
@DonkeyShot21 DonkeyShot21 merged commit 48e669e into main Jul 14, 2022
@vturrisi vturrisi deleted the h5 branch July 14, 2022 11:31
@vturrisi vturrisi changed the title Added support for H5 Added support for H5 data, improved scripts and data handling Jul 14, 2022
@trungpx
Copy link

trungpx commented Aug 5, 2022

Hello @vturrisi and @DonkeyShot21,

Could I ask what is benefit or difference between using data h5 and the traditional imagenet folder?

@vturrisi
Copy link
Owner Author

vturrisi commented Aug 8, 2022

hey @trungpx, you can read about it here: https://www.h5py.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants