FroSSL Implementation #390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
*This pull request uses carry forward flags. Click here to find out more.
|
vturrisi
reviewed
Aug 8, 2024
| invariance_term = invariance_tradeoff * invariance_term | ||
|
|
||
| if logger is not None: | ||
| logger("frossl_regularization_loss", -regularization_term, sync_dist=True) |
There was a problem hiding this comment.
Is this supposed to be logged as - regularization_term? I would also say that for consistency with the other loss functions, it's better if you return the individual elements and log them on the method's side. You could return the two terms and sum them in the method.
|
@OFSkean Apart from my comment, the other parts look good. It's just missing the documentation for the method, results/checkpoints, and these to the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of FroSSL from https://arxiv.org/pdf/2310.02903
I am currently training a ResNet-18 on ImageNet100 to make sure everything is working properly