Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Form disabled no effect on Upload #7110

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix: Form disabled no effect on Upload #7110

merged 2 commits into from
Dec 18, 2023

Conversation

JavanShen
Copy link
Contributor

@puppet-666
Copy link
Contributor

这里删掉不就没了默认值了么，那就和文档不一致了吧，应该是要修复传值问题？

@JavanShen
Copy link
Contributor Author

这里删掉不就没了默认值了么，那就和文档不一致了吧，应该是要修复传值问题？

我的理解是文档中的默认值不一定就要和代码保持一致，更多的是告知开发者这个组件的默认表现形式是这个

@puppet-666
Copy link
Contributor

这里删掉不就没了默认值了么，那就和文档不一致了吧，应该是要修复传值问题？

我的理解是文档中的默认值不一定就要和代码保持一致，更多的是告知开发者这个组件的默认表现形式是这个

意思是可以改，但最好文档也同步一下。既然文档上有默认值，你代码和文档都有出入，那我还能信任文档吗？

@tangjinzhou tangjinzhou merged commit 1fc1097 into vueComponent:main Dec 18, 2023
3 of 4 checks passed
@JavanShen JavanShen deleted the fix-upload branch December 20, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JavanShen @puppet-666 @tangjinzhou