Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 避免在焦点元素或其祖先元素上使用 aria-hidden; #7778

Closed

Conversation

HongHaiyang
Copy link

用于修复较新版本的 Chrome 浏览器对在焦点元素上使用 aria-hidden 的报错

image 目前在这个 issue 中有人提到 https://github.com//issues/7749 在评论区中有人提到可以使用 ```` .ant-modal div[aria-hidden="true"] { display: none !important; } ````

来临时规避,但是我们项目中实际使用的话在某些场景 tab 展示会有异常
参考 antd for react 的处理方式:
ant-design/ant-design#50170 (comment)
react-component/dialog@df21b0e
把相关使用到 aria-hidden 的地方给删除了

@Jzow
Copy link

Jzow commented Aug 13, 2024

这个也会直接影响Modal,我没看到Modal相关的aria-hidden 移除,这个fix是否验证测试过了

@Jzow
Copy link

Jzow commented Aug 13, 2024

@tangjinzhou

@HongHaiyang
Copy link
Author

这个也会直接影响Modal,我没看到Modal相关的aria-hidden 移除,这个fix是否验证测试过了

Modal 组件内部依赖的 dialog,pr 里把 dialog 上的aria-hidden 移除了

@zhangchenna
Copy link

来个人合并 pr 吧。。。

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 20, 2024
@github-actions github-actions bot closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants