Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix subscription test #1547

Merged
merged 1 commit into from
Mar 29, 2024
Merged

test: fix subscription test #1547

merged 1 commit into from
Mar 29, 2024

Conversation

nickmessing
Copy link
Member

@nickmessing nickmessing commented Mar 27, 2024

Cause (from video): First character on second typing is ignored in github workflow, so it's "af" instead of "Waf"
Idea: Vue doesn't get to render the updated input before cypress tries to type again
Fix strategy: Check for input to be empty before typing again

@Akryum Akryum merged commit dbd1c8d into vuejs:v4 Mar 29, 2024
11 checks passed
@nickmessing nickmessing deleted the nick/fix-test branch March 29, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants