fix(reactivity): mutating a readonly ref nested in a reactive object …

…should fail. fix: #5042
vuejs · Dec 5, 2021 · 9797485 · 9797485
1 parent 2d4f455
commit 9797485
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/reactivity/__tests__/readonly.spec.ts b/packages/reactivity/__tests__/readonly.spec.ts
@@ -474,4 +474,15 @@ describe('reactivity/readonly', () => {
     expect(rr.foo).toBe(r)
     expect(isReadonly(rr.foo)).toBe(true)
   })
+
+  test('attemptingt to write to a readonly ref nested in a reactive object should fail', () => {
+    const r = ref(false)
+    const ror = readonly(r)
+    const obj = reactive({ ror })
+    try {
+      obj.ror = true
+    } catch (e) {}
+
+    expect(obj.ror).toBe(false)
+  })
 })
diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts
@@ -147,6 +147,9 @@ function createSetter(shallow = false) {
     receiver: object
   ): boolean {
     let oldValue = (target as any)[key]
+    if (isReadonly(oldValue) && isRef(oldValue)) {
+      return false
+    }
     if (!shallow && !isReadonly(value)) {
       value = toRaw(value)
       oldValue = toRaw(oldValue)