Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Transition appear> seems not working on SSR #12046

Closed
liqueflies opened this issue Sep 26, 2024 · 2 comments · Fixed by #12047
Closed

<Transition appear> seems not working on SSR #12046

liqueflies opened this issue Sep 26, 2024 · 2 comments · Fixed by #12047
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: ssr scope: transition

Comments

@liqueflies
Copy link

Vue version

2.5.9

Link to minimal reproduction

https://stackblitz.com/edit/github-jer1rm

Steps to reproduce

As noticed here with the nuxt maintainers, the seems not working on the SSR.

There was an issue running here on the vuejs/core closed as resolved, but is not working again.

What is expected?

Reloading the page should perform the appear animation
Also the @Enter callback sould be invoked correctly

What is actually happening?

First appear animation is not showing

System Info

No response

Any additional comments?

No response
@edison1105
Copy link
Member

edison1105 commented Sep 27, 2024 •
edited
Loading

It works fine without Suspense Playground
but not working with Suspense Playground

@edison1105 edison1105 added scope: transition scope: suspense scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Sep 27, 2024
@edison1105 edison1105 mentioned this issue Sep 27, 2024
Merged
@liqueflies
Copy link
Author

It works fine without Suspense Playground but not working with Suspense Playground

That's probably why is not working in nuxt?

yyx990803 pushed a commit that referenced this issue Oct 11, 2024
@edison1105
fix(transition/ssr): make transition appear work with Suspense in SSR (…
f1a4f67 
…#12047)

close #12046
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: ssr scope: transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transition/ssr): make transition appear work with Suspense in SSR vuejs/core
2 participants
@edison1105 @liqueflies