Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@vue/server-renderer renderToString generating incorrect src URL for images within a router link #3447

Closed
lukewarlow opened this issue Mar 18, 2021 · 0 comments · Fixed by #3448
Closed

@vue/server-renderer renderToString generating incorrect src URL for images within a router link #3447

lukewarlow opened this issue Mar 18, 2021 · 0 comments · Fixed by #3448
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr

Comments

@lukewarlow
Copy link

Version

3.0.7

Reproduction link

https://github.com/lukewarlow/vue-server-render-bug

Steps to reproduce

Clone the git repository. Run npm install and then npm run generate. This will generate a dist/static/index.html file.

What is expected?

The generated html file should have two img tags which point to different images. As seen in the source file at src/views/Home.vue.

What is actually happening?

In dist/static/index.html you will be able to see that both the generated img tags have the same src URL.
@HcySunYang HcySunYang added 🐞 bug Something isn't working scope: ssr labels Mar 19, 2021
@HcySunYang HcySunYang mentioned this issue Mar 19, 2021
Merged
@HcySunYang HcySunYang added the ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. label Mar 19, 2021
yyx990803 pushed a commit that referenced this issue Mar 25, 2021
@HcySunYang
fix(compiler-ssr): keep the order of imports expression for the fallb…
49f4072 
…ack branch of SSR (#3448)

fix #3447
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-ssr): keep the order of imports expression for the fallback branch of SSR
2 participants
@HcySunYang @lukewarlow