Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR leaks internal properties in the rendered output #5563

Closed
paraboul opened this issue Mar 10, 2022 · 0 comments · Fixed by #5564
Closed

SSR leaks internal properties in the rendered output #5563

paraboul opened this issue Mar 10, 2022 · 0 comments · Fixed by #5564
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: ssr

Comments

@paraboul
Copy link
Contributor

Version

3.2.31

Reproduction link

sfc.vuejs.org/

Steps to reproduce

  1. Create a SFC with a single root node.
  2. Assign a template ref to that root node
  3. render app with "renderToString()"
  4. The output generated code has a "ref_key" property.

What is expected?

The generated HTML should not contains any internal property used by the code generator

What is actually happening?

The generated HTML contains a "ref_key" property

This only happen if the SFC has a single node where the template ref is assigned.
paraboul added a commit to paraboul/core that referenced this issue Mar 10, 2022
@paraboul
Fix: missing reserved prop ref_key, leading to unwanted property leak…
c8a18ad 
… in SSR code generation. (fix vuejs#5563)
@paraboul paraboul mentioned this issue Mar 10, 2022
Merged
@LinusBorg LinusBorg added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working and removed ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Mar 10, 2022
yyx990803 pushed a commit that referenced this issue Apr 14, 2022
@paraboul
fix(ssr): avoid rendering reserved internal keys in output (#5564)
cc238cd 
fix #5563
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: ssr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: missing reserved props ref_key & ref_for (fix #5563) paraboul/core
2 participants
@paraboul @LinusBorg