Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): delete stale slots which are present but undefined #6484

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Aug 16, 2022

fixes #9109

If slots.loader becomes undefined, slots.default in LoaderSlot was still the old value because the key is still present

<v-field>
  <template v-if="custom" #loader>
    <v-progress-linear />
  </template>
</v-field>
<LoaderSlot v-slots={{ default: slots.loader }} />

@haiweilian
Copy link

@sxzz Will it be merged?

@zhangzhonghe zhangzhonghe added the need test The PR has missing test cases. label Dec 12, 2022
@zhangzhonghe
Copy link
Member

@KaelWD Thanks for the PR, could you add a test?

@KaelWD
Copy link
Contributor Author

KaelWD commented Mar 21, 2023

@zhangzhonghe tests updated

@sxzz

This comment was marked as outdated.

@vue-bot

This comment was marked as outdated.

@sxzz sxzz force-pushed the fix/delete-defined-undefined-slots branch from fa25bff to 47e2f6f Compare September 1, 2023 17:34
@sxzz
Copy link
Member

sxzz commented Sep 1, 2023

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 1, 2023

📝 Ran ecosystem CI: Open

suite result
nuxt ✅ success
pinia ✅ success
quasar ✅ success
router ✅ success
test-utils ✅ success
vant ✅ success
vite-plugin-vue ✅ success
vitepress ✅ success
vue-i18n ✅ success
vue-macros ❌ failure
vuetify ✅ success
vueuse ✅ success
vue-simple-compiler ✅ success

@sxzz sxzz linked an issue Sep 1, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+4 B) 32.6 kB (+1 B) 29.5 kB (-3 B)
vue.global.prod.js 132 kB (+4 B) 49.3 kB 44.3 kB (-16 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB (+4 B) 18.8 kB (+1 B) 17.2 kB (+55 B)
createSSRApp 50.6 kB (+4 B) 20 kB (+2 B) 18.2 kB (+3 B)
defineCustomElement 50.3 kB (+4 B) 19.6 kB (+2 B) 17.9 kB (+1 B)
overall 61.2 kB (+4 B) 23.7 kB (+1 B) 21.5 kB (-40 B)

@sxzz
Copy link
Member

sxzz commented Sep 2, 2023

CI failed. Could you please format your files? pnpm run format

@KaelWD
Copy link
Contributor Author

KaelWD commented Sep 7, 2023

That adds a bunch of other changes in unrelated files.

@sxzz sxzz added ready to merge The PR is ready to be merged. ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. and removed ready for review This PR requires more reviews labels Sep 19, 2023
@yyx990803 yyx990803 merged commit 75b8722 into vuejs:main Oct 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged. scope: slots
Projects
Development

Successfully merging this pull request may close these issues.

JSX - Slots reactivity is not supported
9 participants