Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): delete stale slots which are present but undefined #6484

Merged
merged 4 commits into from
Oct 20, 2023
Merged

fix(runtime-core): delete stale slots which are present but undefined #6484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
487928e
fix(runtime-core): delete stale slots which are present but undefined
KaelWD Aug 16, 2022
47e2f6f
update tests
KaelWD Mar 20, 2023
fc4a41d
Merge branch 'main' into fix/delete-defined-undefined-slots
KaelWD Sep 7, 2023
3e2286d
remove trailing commas
KaelWD Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/runtime-core/__tests__/componentSlots.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,11 @@ describe('component: slots', () => {
}

const oldSlots = {
header: 'header'
header: 'header',
footer: undefined
}
const newSlots = {
header: undefined,
footer: 'footer'
}

Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/componentSlots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export const updateSlots = (
// delete stale slots
if (needDeletionCheck) {
for (const key in slots) {
if (!isInternalKey(key) && !(key in deletionComparisonTarget)) {
if (!isInternalKey(key) && deletionComparisonTarget[key] == null) {
delete slots[key]
}
}
Expand Down