Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Transition): separate old vnode scope to avoid detached node is kept (fix #11782) #11789

Closed

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Sep 3, 2024

close #11782

Initially tried to clean up postClone after it will no longer be used. But since postClone is passed through all cloned hooks, it seems difficult to fix in that way.

Instead, I have wrapped the area using old vnode with a block to avoid keeping postClone closure retains it. it is much simpler because we don't have to track cloned hooks nor postClone is actually no longer needed.

If there is better solution I don't notice, please let me know.

Copy link

github-actions bot commented Sep 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+2 B) 37.6 kB (-5 B) 33.8 kB (-44 B)
vue.global.prod.js 159 kB (+2 B) 57.5 kB (-4 B) 51.2 kB (+9 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB (+2 B) 26.3 kB (-2 B) 23.9 kB (+57 B)

Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11789

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11789

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11789

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11789

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11789

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11789

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11789

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11789

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11789

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11789

vue

pnpm add https://pkg.pr.new/vue@11789

commit: 520476b

@ktsn
Copy link
Member Author

ktsn commented Sep 3, 2024

Oh! a fix is already submitted, closing this one :) #11788

@ktsn ktsn closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Transition> retains detached DOM nodes that already left
1 participant