Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): reload async child wrapped in Suspense + KeepAlive #11907

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

edison1105
Copy link
Member

close #11868

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11907

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11907

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11907

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11907

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11907

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11907

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11907

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11907

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11907

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11907

vue

pnpm add https://pkg.pr.new/vue@11907

commit: 19c1762

@edison1105 edison1105 marked this pull request as draft September 12, 2024 09:56
@edison1105 edison1105 marked this pull request as ready for review September 12, 2024 13:34
@edison1105 edison1105 added scope: hmr ready for review This PR requires more reviews ready to merge The PR is ready to be merged. labels Sep 12, 2024
@yyx990803 yyx990803 merged commit 10a2c60 into main Sep 13, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/11868 branch September 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR requires more reviews ready to merge The PR is ready to be merged. scope: hmr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HMR] Triggered within Suspense Cannot read properties of null (reading 'insertBefore')
2 participants