-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compiler-sfc): support sass modern api #11992
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
❌ Deploy Preview for vue-sfc-playground failed.
|
Thanks for this PR and I made small tweaks 78f5696 |
/ecosystem-ci run |
34af007
to
78f5696
Compare
📝 Ran ecosystem CI: Open
|
if (map) { | ||
return { | ||
code: result.css.toString(), | ||
map: merge(map, JSON.parse(result.map.toString())), | ||
code: result.css, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The css
type has changed from Buffer
to string
, and toString
is no longer required.
sourceMap
as well
The new API requires Dart Sass 1.45.0+, which was released in 2021. I'm wondering whether there's some way to express that version requirement to ensure that it's met? Maybe through If not, maybe we could try to detect the version in the code? |
@KazariEX @skirtles-code if('compileString' in nodeSaas){
// modern api
} else {
// legacy api
} |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
https://sass-lang.com/documentation/breaking-changes/legacy-js-api