Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): remove comment nodes in runtime-compiler #3394

Closed
wants to merge 2 commits into from
Closed

fix(compiler-core): remove comment nodes in runtime-compiler #3394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1967200
fix(compiler-core): remove commont nodes in runtime-compiler
edison1105 Mar 9, 2021
e5ba7ec
fix(compiler-core): remove comment nodes in runtime-compiler
edison1105 Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler-core/src/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ function parseChildren(
}
// also remove comment nodes in prod by default
if (
!__DEV__ &&
(__GLOBAL__ || __ESM_BROWSER__ || !__DEV__) &&
Copy link
Member

@posva posva Mar 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shouldn't just remove the check of !__DEV__ and explicitly look for context.options.comments === false That wouldn't work by default in production mode

node.type === NodeTypes.COMMENT &&
!context.options.comments
) {
Expand Down