Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): Handle empty strings during template usage analysis of setup bindings. (fix #4599) #4608

Merged
merged 2 commits into from
Sep 16, 2021
Merged

fix(compiler-sfc): Handle empty strings during template usage analysis of setup bindings. (fix #4599) #4608

merged 2 commits into from
Sep 16, 2021

Conversation

LinusBorg
Copy link
Member

empty strings could trip up usage detection in templates during script setup compilation.

fix #4599

@github-actions
Copy link

Size report

Path Size
vue.global.prod.js 45.83 KB (0%)
runtime-dom.global.prod.js 30.22 KB (0%)
size-check.global.prod.js 17.41 KB (0%)

@LinusBorg LinusBorg changed the title fix(compiler-sfc): properly analyze destructured bindings with dynamic keys (fix #4599) fix(compiler-sfc): Handle empty strings during template usage analysis of setup bindings. (fix #4599) Sep 16, 2021
@yyx990803 yyx990803 merged commit bdb1a79 into master Sep 16, 2021
@yyx990803 yyx990803 deleted the fix-issue-4599 branch September 16, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henribru henribru henribru left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$setup.bar is not a function with script setup
3 participants
@LinusBorg @henribru @yyx990803