Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): render teleport inside async component #5187

Merged
merged 2 commits into from
May 13, 2022
Merged

fix(ssr): render teleport inside async component #5187

merged 2 commits into from
May 13, 2022

Conversation

adamjedlicka
Copy link
Contributor

@adamjedlicka adamjedlicka commented Dec 30, 2021

Teleports inside async components weren't SSR rendered into the ctx.teleports but were in the ctx.__teleportBuffers. This PR fixes the issue.

@adamjedlicka adamjedlicka changed the title fix(ssr #4440): render teleport inside async component fix(#4440): render teleport inside async component Dec 30, 2021
@adamjedlicka
Copy link
Contributor Author

Closes #4440

@adamjedlicka adamjedlicka changed the title fix(#4440): render teleport inside async component fix(ssr): render teleport inside async component Jan 6, 2022
@awacode21
Copy link

i am dealing with the exakt same problem. Is there anything new on when this PR will be merged?

@LinusBorg LinusBorg added scope: teleport scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: ssr scope: teleport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants