Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): fix keep-alive component causing hydration node mismatch (fix #4817) #5636

Closed
wants to merge 1 commit into from

Conversation

mefcorvi
Copy link
Contributor

Render function of KeepAlive component returns the first child in the client-side mode, but in the SSR mode it returns array of children causing hydration issues. This PR adjusts render function so it returns same results in both modes. Fixes #4817.

@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 6b0b610
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6241b9143472210008117936
😎 Deploy Preview https://deploy-preview-5636--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 6b0b610
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6241b9140417a100081ebf41
😎 Deploy Preview https://deploy-preview-5636--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 6b0b610
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6241b91480245b00080587b2
😎 Deploy Preview https://deploy-preview-5636--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yyx990803
Copy link
Member

Thanks for the PR! Manually picked in 0841b9b - in the future when submitting PRs, make sure to do it from a separate branch and enable edits by maintainer.

@yyx990803 yyx990803 closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encounter " Hydration node mismatch" when using keep-alive in ssr rendering
2 participants