Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): when Transition reports a warning about 'can only be used on a single element or component', it ignores the comments node. (fix #5675) #5708

Closed
wants to merge 2 commits into from
Closed

fix(runtime-core): when Transition reports a warning about 'can only be used on a single element or component', it ignores the comments node. (fix #5675) #5708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9a4266
fix(runtime-core): when Transition reports a warning about 'can only …
baiwusanyu-c Apr 13, 2022
72db792
Merge remote-tracking branch 'origin/main' into fix/transition
baiwusanyu-c Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/runtime-core/src/components/BaseTransition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { ShapeFlags, PatchFlags } from '@vue/shared'
import { onBeforeUnmount, onMounted } from '../apiLifecycle'
import { RendererElement } from '../renderer'


export interface BaseTransitionProps<HostElement = RendererElement> {
mode?: 'in-out' | 'out-in' | 'default'
appear?: boolean
Expand Down Expand Up @@ -140,16 +141,19 @@ const BaseTransitionImpl: ComponentOptions = {
const state = useTransitionState()

let prevTransitionKey: any

const filterCommentChild = (children:Array<VNode>) =>{
return children.filter((child:VNode)=>{
return child.type !== Comment
})
}
return () => {
const children =
slots.default && getTransitionRawChildren(slots.default(), true)
if (!children || !children.length) {
return
}

// warn multiple elements
if (__DEV__ && children.length > 1) {
if (__DEV__ && filterCommentChild(children).length > 1) {
warn(
'<transition> can only be used on a single element or component. Use ' +
'<transition-group> for lists.'
Expand Down