Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): avoid number type transition child key duplicating with index key #5779

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(runtime-core): avoid number type transition child key duplicating with index key #5779

wants to merge 5 commits into from

Conversation

yuwu9145
Copy link
Contributor

@yuwu9145 yuwu9145 commented Apr 22, 2022 •
edited
Loading

close #5761

@netlify
Copy link

netlify bot commented Apr 22, 2022 •
edited
Loading

✅ Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 0050a37
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/626784d925b6d200086be919
😎 Deploy Preview https://deploy-preview-5779--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2022 •
edited
Loading

✅ Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 0050a37
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/626784d9e9d1ed0009a1e475
😎 Deploy Preview https://deploy-preview-5779--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 22, 2022 •
edited
Loading

✅ Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 0050a37
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/626784d900dba500088a5c3a
😎 Deploy Preview https://deploy-preview-5779--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yuwu9145 yuwu9145 force-pushed the fix-5762 branch 2 times, most recently from 45830e3 to 74cddb5 Compare April 22, 2022 04:52
@yuwu9145 yuwu9145 changed the title fix(runtime-core): respect child index position in transition group w… fix(runtime-core): respect child index position when calculating key Apr 22, 2022
@yuwu9145 yuwu9145 force-pushed the fix-5762 branch 2 times, most recently from 7e530b5 to 9f4facb Compare April 22, 2022 11:24
@yuwu9145 yuwu9145 changed the title fix(runtime-core): respect child index position when calculating key fix(compiler-core): v-if key increment also based on other type siblings Apr 22, 2022
@yuwu9145
Copy link
Contributor Author

I will add tests soon

@yuwu9145 yuwu9145 force-pushed the fix-5762 branch 2 times, most recently from dad9798 to cc93966 Compare April 22, 2022 12:10
@yuwu9145 yuwu9145 mentioned this pull request Apr 22, 2022
Open
@yuwu9145 yuwu9145 changed the title fix(compiler-core): v-if key increment also based on other type siblings fix(runtime-core): avoid number type transition child key duplicating with index key Apr 22, 2022
@yuwu9145 yuwu9145 force-pushed the fix-5762 branch 2 times, most recently from ea78b49 to 0050a37 Compare April 26, 2022 05:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+24 B) 37.7 kB (+2 B) 33.9 kB (-33 B)
vue.global.prod.js 159 kB (+24 B) 57.5 kB 51.2 kB (+60 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.8 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB (+24 B) 26.3 kB (+3 B) 23.9 kB (+13 B)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 2, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@5779

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@5779

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@5779

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@5779

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@5779

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@5779

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@5779

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@5779

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@5779

vue

pnpm add https://pkg.pr.new/vue@5779

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@5779

commit: 0fbfb31

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔩 p2-edge-case labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔩 p2-edge-case ready to merge The PR is ready to be merged. scope: transition
Projects
Issue / PR Management
Status: Stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate key for transition group fragment when child has v-if
3 participants
@yuwu9145 @haoqunjiang @edison1105