Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): support resolve type declaration from normal script #5831

Merged
merged 8 commits into from
Feb 1, 2023
Merged

fix(compiler-sfc): support resolve type declaration from normal script #5831

merged 8 commits into from
Feb 1, 2023

Conversation

edison1105
Copy link
Member

fix #5830

@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit d261c02
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/63c7a4313f92e7000a48be72

@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 72f8bc2
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63c7a537f1bf990008fd71b2

@netlify
Copy link

netlify bot commented Apr 29, 2022 •
edited
Loading

✅ Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 66352d5
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/626bf2318401d5000875361b
😎 Deploy Preview https://deploy-preview-5831--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@edison1105
fix(compiler-sfc): support resolve type declaration from normal script
9c8f114 
fix(compiler-sfc): support resolve type declaration from normal script

fix(compiler-sfc): support resolve type declaration from normal script

update test case
@edison1105 edison1105 marked this pull request as draft April 29, 2022 08:17
@edison1105 edison1105 marked this pull request as ready for review April 29, 2022 13:11
@edison1105 edison1105 changed the title fix(compiler-sfc): support resolve prop type declaration from normal script fix(compiler-sfc): support resolve type declaration from normal script Apr 29, 2022
@edison1105 edison1105 changed the title fix(compiler-sfc): support resolve prop type declaration from normal script fix(compiler-sfc): support resolve type declaration from normal script Apr 29, 2022
@sapphi-red sapphi-red mentioned this pull request May 3, 2022
Closed
7 tasks
@edison1105 edison1105 mentioned this pull request Jun 25, 2022
Closed
@vaban-ru
Copy link

Is there any news on solving this error?

@PixsaOJ
Copy link

PixsaOJ commented Sep 16, 2022

Is there any news on solving this error?

Call variable primary something else.

sxzz
sxzz reviewed Nov 12, 2022
View reviewed changes
packages/compiler-sfc/src/compileScript.ts Outdated Show resolved Hide resolved
packages/compiler-sfc/src/compileScript.ts Outdated Show resolved Hide resolved
@yyx990803 yyx990803 merged commit 30399d4 into vuejs:main Feb 1, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@edison1105 @zhangzhonghe
fix(compiler-sfc): support resolving type declaration from normal scr…
4fd7bc7 
…ipt (vuejs#5831)

fix vuejs#5830
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
@edison1105 @IAmSSH
fix(compiler-sfc): support resolving type declaration from normal scr…
f1c77a3 
…ipt (vuejs#5831)

fix vuejs#5830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

Assignees
No one assigned
Labels
scope: sfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler crashes in some situations when the word "zoom?" is present
5 participants
@edison1105 @vaban-ru @PixsaOJ @sxzz @yyx990803