fix(runtime-core): Lifecycle hooks should support callbacks shared by reference (fix #6686) #6687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
force-pushed
the
linusborg/fix-shared-hook-callback-6686
branch
from
6d6561d
to
2fad93c
Compare
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current deduping implementation of
injectHookrelies on lifecycle callbacks always being created within setup.When using i.e. an imported function directly as a hook callback, it will not reliably be run for each instance of a component.
This PR wraps each received callback in another arrow function in in order to ensure that each component instance has its own distinct copy of the callback.