Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transition): get root el of DEV_FRAGMENT_ROOT #6761

Conversation

jonaskuske
Copy link
Contributor

@jonaskuske jonaskuske commented Sep 26, 2022

fix #6745


___

an alternative to re-assigning el would be something like

prevChildren = prevChildren.map((child) => {
  if (DEV_ROOT_FRAGMENT) {
    const clone = cloneVNode(child)
    clone.el = elementRoot.el
    return clone
  }
  return child
})

but I don't think the cloning is actually necessary here. Not sure though.

Copy link

github-actions bot commented Mar 1, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB (+27 B) 34.4 kB (+33 B) 31 kB (+42 B)
vue.global.prod.js 148 kB (+27 B) 53.7 kB (+22 B) 47.9 kB (+12 B)

Usages

Name Size Gzip Brotli
createApp 50.7 kB 19.8 kB 18.1 kB
createSSRApp 54.1 kB 21.1 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.7 kB
overall 64.4 kB 24.8 kB 22.5 kB

@jonaskuske jonaskuske force-pushed the fix/dev-root-fragment-in-transition-group branch from 450e0e3 to c88b488 Compare March 1, 2024 13:50
@skirtles-code
Copy link
Contributor

I think this may have been fixed in 3.4.22 by #9421.

@edison1105 edison1105 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

TransitionGroup getBoundingClientRect is not a function
3 participants