fix(compiler-core): No access this through function declaration in <script setup>

[godxiaoji]

fix #6822

[sxzz]

Could you please add unit tests of the issue?

[godxiaoji]

Could you please add unit tests of the issue?

Case added. Thanks.

[sxzz]

Why check BindingTypes here? Consider this example, the problem is still existing.

[godxiaoji]

1. I had to make sure it's a function identifier with parents.type. Then use .bind() to change the scope to undefined.
2. Considered with the smallest dimension of the issue, including the following situations when type is BindingTypes.SETUP_CONST or BindingTypes.SETUP_LET:

// BindingTypes.SETUP_LET
let foo = () => {}
let foo = function() {}

// BindingTypes.SETUP_CONST
const foo = () => {}
const foo = function {}
function foo() {}

[sxzz]

There are many kinds of BindingTypes. For generality, I don't think it's necessary to check BindingTypes here.

Or if you have a better solution to fix the example I provided, it's also all right.

[godxiaoji]

Updated! The previous judgment was poor, and the following conditions are also met.

const foo = ref(function(a, b) {
  console.log(this)
})

[sxzz]

Great, but CI is failed. You can push an empty commit git commit --allow-empty -m "Empty-Commit" to re-run CI.

[posva]

Thanks! It's actually the other way around, it should fail in dev (like it does in prod): vitejs/vite#3872 (comment)

[sxzz]

@posva This PR is true to fix - it will fail in both dev and prod mode.

[posva]

You are right, I was a bit too fast on reading that .bind()

[pkg-pr-new]

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@6827

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@6827

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@6827

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@6827

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@6827

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@6827

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@6827

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@6827

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@6827

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@6827

vue

pnpm add https://pkg.pr.new/vue@6827

commit: 6ebd836

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB	38 kB	34.2 kB
vue.global.prod.js	159 kB	57.9 kB	51.4 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.9 kB	18.3 kB	16.7 kB
createApp	55 kB	21.3 kB	19.4 kB
createSSRApp	59 kB	23 kB	20.9 kB
defineCustomElement	59.8 kB	22.8 kB	20.8 kB
overall	68.7 kB	26.3 kB	24 kB