Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): Fix cssvars reporting error when teleport is disabled #7341

Merged
merged 27 commits into from
Oct 20, 2023
Merged

fix(runtime-core): Fix cssvars reporting error when teleport is disabled #7341

merged 27 commits into from
Oct 20, 2023

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented Dec 14, 2022 •
edited
Loading

close: #7342

@baiwusanyu-c baiwusanyu-c marked this pull request as draft December 14, 2022 07:02
@baiwusanyu-c baiwusanyu-c reopened this Dec 14, 2022
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review December 14, 2022 07:16
@skirtles-code skirtles-code mentioned this pull request Dec 17, 2022
Open
@skirtles-code skirtles-code mentioned this pull request Mar 11, 2023
Closed
@LinusBorg LinusBorg added scope: teleport 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: sfc-style-vars labels Mar 13, 2023
@vercel
Copy link

vercel bot commented Apr 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
sfc-playground ⬜️ Ignored (Inspect) Apr 6, 2023 0:44am

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.8 kB (+3 B) 32.6 kB (+1 B) 29.5 kB (+8 B)
vue.global.prod.js 132 kB (+3 B) 49.3 kB (+2 B) 44.3 kB (+40 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@haoqunjiang
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 19, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
quasar ❌ failure ❌ failure
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ❌ failure ❌ failure
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@haoqunjiang haoqunjiang added the ready to merge The PR is ready to be merged. label Oct 19, 2023
@yyx990803 yyx990803 merged commit 8f0472c into vuejs:main Oct 20, 2023
9 checks passed
yyx990803 pushed a commit that referenced this pull request Oct 21, 2023
@baiwusanyu-c @yyx990803
fix(runtime-core): fix error when using cssvars with disabled teleport (
5c9ade5 
#7341)

close #7342
lumozx pushed a commit to lumozx/core that referenced this pull request Oct 21, 2023
@baiwusanyu-c @lumozx
fix(runtime-core): fix error when using cssvars with disabled teleport (
feabcfa 
vuejs#7341)

close vuejs#7342
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/errorTeleportCSSVars branch October 22, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: sfc-style-vars scope: teleport
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSSVars reporting error when teleport is disabled
5 participants
@baiwusanyu-c @haoqunjiang @vue-bot @yyx990803 @LinusBorg