fix(runtime-core): pruneCacheEntry rectify the judgment logic (fix #7355) #7510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ejs#7355) keep-alive component status abnormal when cache items more than its max, after debugging, I found that its judge 2 VNode is same logic is wrong(as cached.type !== current.type).
❌ Deploy Preview for vuejs-coverage failed.
|
|
@LinusBorg Hoping to help approval workflow and review code #7355 |
|
I've applied this patch locally and it seems to address my initial issue. |
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
…me type but different keys (vuejs#7510) fix vuejs#7355
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
…me type but different keys (vuejs#7510) fix vuejs#7355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep-alive component status abnormal when cache items more than its max, after debugging, I found that it judge 2 VNode is same logic is wrong(as
cached.type !== current.type).Issues link: #7355
Playground Before:
https://codesandbox.io/s/emit-issue-kezqfe