fix(compiler-ssr): TransitionGroup owns style-scoped properties on SSR #7557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
baiwusanyu-c
added
the
❗ p4-important
Size ReportBundles
Usages
|
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
haoqunjiang
approved these changes
Oct 19, 2023
yyx990803
force-pushed
the
bwsy/fix/transitionGroupStyleSSR
branch
from
cfbe80c
to
ec4045f
Compare
yyx990803
reviewed
Oct 20, 2023
| if (tag.type === NodeTypes.DIRECTIVE) { | ||
| // dynamic :tag | ||
| context.pushStringPart(`<`) | ||
| context.pushStringPart(tag.exp!) | ||
| if (propsExp) { | ||
| context.pushStringPart(propsExp) | ||
| } | ||
| if (scopeId) { | ||
| context.pushStringPart(` ${scopeId}`) |
There was a problem hiding this comment.
Changes made: we need to ensure a space before the scopeId since propsExp can either be non-existent or render an empty string. If there is no space, the scopeId will be connected to the open tag name and cause error.
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #7554