Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): ensure suspense creates dep's setupEffect with correct optimized flag (fix #7688) #7689

Merged
merged 3 commits into from
May 31, 2024

Conversation

LinusBorg
Copy link
Member

This attempts to fix #7688

I verified that it solves the problem stated in that issue, and all existing tests pass.

But I haven't found a good way to write a test case for this so I'm opening it as a draft.

close: #7688

@LinusBorg LinusBorg changed the title fix(runtime-core): ensure suspense creates dep's setupEffect with correct optimized flag (fix #7688( fix(runtime-core): ensure suspense creates dep's setupEffect with correct optimized flag (fix #7688) Feb 11, 2023
@LinusBorg LinusBorg added need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. scope: suspense 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 11, 2023
@LinusBorg LinusBorg marked this pull request as ready for review February 12, 2023 10:54
@IcetCode IcetCode mentioned this pull request Jun 16, 2023
3 tasks
@jd-solanki
Copy link

Hi team,

I will be doing some refactoring in Anu's codebase and doing so might break existing PR that relies on this PR. Is there any chance that it can get merged any time soon?

Regards.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 91 kB (+4 B) 34.6 kB (-3 B) 31.2 kB (+2 B)
vue.global.prod.js 148 kB (+4 B) 53.8 kB (-3 B) 48.1 kB (-77 B)

Usages

Name Size Gzip Brotli
createApp 51 kB (+2 B) 19.9 kB (+1 B) 18.2 kB (+3 B)
createSSRApp 54.3 kB (+2 B) 21.3 kB (+2 B) 19.4 kB (-71 B)
defineCustomElement 53.2 kB (+2 B) 20.7 kB (+2 B) 18.9 kB (-6 B)
overall 64.7 kB (+4 B) 25 kB (-1 B) 22.6 kB (-16 B)

@yyx990803 yyx990803 merged commit c521f95 into main May 31, 2024
15 checks passed
@yyx990803 yyx990803 deleted the linusborg/suspense-optimized-bug-7688 branch May 31, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. scope: suspense
Projects
Development

Successfully merging this pull request may close these issues.

watch() does not work after building for production using npm run build
3 participants