style: add @typescript-eslint/eslint-plugin plugin
#8978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
approved these changes
Aug 15, 2023
sxzz
force-pushed
the
chore-remove-ts-ignore
branch
from
59237d0
to
1082e14
Compare
Size ReportBundles
Usages
|
sxzz
force-pushed
the
chore-remove-ts-ignore
branch
from
1082e14
to
2578557
Compare
haoqunjiang
reviewed
Sep 4, 2023
There was a problem hiding this comment.
It would be more helpful and more comprehensive if we could add an ESLint rule in the project to avoid such issues from happening again. https://typescript-eslint.io/rules/prefer-ts-expect-error
|
I changed the base branch to Also #8565 |
sxzz
changed the title
Alfred-Skyblue
changed the title
@ts-expect-error to replace @ts-ignore
|
I added the |
Alfred-Skyblue
changed the title
@ts-expect-error to replace @ts-ignore@typescript-eslinteslint-plugin plugin to eslint
Alfred-Skyblue
changed the title
@typescript-eslinteslint-plugin plugin to eslint@typescript-eslint/eslint-plugin plugin to eslint
Alfred-Skyblue
commented
Sep 9, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
| "include": ["packages", "scripts", "./*.ts"] | |||
There was a problem hiding this comment.
The tsconfig.eslint.json added here is to prevent ESLint from reporting errors for files that are not matched. Please refer to: https://typescript-eslint.io/linting/troubleshooting/#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file
sxzz
force-pushed
the
chore/style
branch
3 times, most recently
from
b96fea8
to
de5f795
Compare
sxzz
force-pushed
the
chore-remove-ts-ignore
branch
3 times, most recently
from
c0bd115
to
1312b63
Compare
Co-authored-by: 丶远方 <[email protected]>
sxzz
force-pushed
the
chore-remove-ts-ignore
branch
from
1312b63
to
8aedc87
Compare
sxzz
changed the title
@typescript-eslint/eslint-plugin plugin to eslint@typescript-eslint/eslint-plugin plugin
sxzz
added a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz
added a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz
added a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz
added a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the following rules using the
@typescript-eslint/eslint-plugin:@typescript-eslint/prefer-ts-expect-error: replace@ts-ignorewith@ts-expect-error@typescript-eslint/no-unnecessary-type-assertion: avoid unnecessary type assertions@typescript-eslint/consistent-type-imports: use thetypekeyword when importing types@typescript-eslint/no-import-type-side-effects: enforce the use of top-level import type qualifier when an import only has specifiers with inline type qualifiers@typescript-eslint/consistent-indexed-object-style: ensure consistent usage of indexed object access style in TypeScript codehttps://typescript-eslint.io/rules/