Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-dom): add xmlns:xlink to SVGAttributes #9300

Merged
merged 9 commits into from
Dec 8, 2023
Merged

feat(runtime-dom): add xmlns:xlink to SVGAttributes #9300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
182bd35
types(runtime-dom): add `xmlns:xlink` to `SVGAttributes`
Alfred-Skyblue Sep 27, 2023
208c6e0
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Sep 27, 2023
82adcba
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Oct 20, 2023
123ef07
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Oct 20, 2023
d1444bd
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Oct 20, 2023
4f40a34
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Oct 31, 2023
ea56584
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Nov 9, 2023
6bb5d7e
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Nov 10, 2023
825a0d0
Merge branch 'main' into fix/svg-type
Alfred-Skyblue Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/dts-test/tsx.test-d.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,11 @@ expectType<JSX.Element>(
)
// @ts-expect-error
;<Suspense onResolve={123} />

// svg
expectType<JSX.Element>(
<svg
xmlnsXlink="http://www.w3.org/1999/xlink"
xmlns="http://www.w3.org/2000/svg"
/>
)
1 change: 1 addition & 0 deletions packages/runtime-dom/src/jsx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,7 @@ export interface SVGAttributes extends AriaAttributes, EventHandlers<Events> {
xlinkTitle?: string
xlinkType?: string
xmlns?: string
xmlnsXlink?: string
y1?: Numberish
y2?: Numberish
y?: Numberish
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/domAttrConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,6 @@ export const isKnownSvgAttr = /*#__PURE__*/ makeMap(
`v-mathematical,values,vector-effect,version,vert-adv-y,vert-origin-x,` +
`vert-origin-y,viewBox,viewTarget,visibility,width,widths,word-spacing,` +
`writing-mode,x,x-height,x1,x2,xChannelSelector,xlink:actuate,xlink:arcrole,` +
`xlink:href,xlink:role,xlink:show,xlink:title,xlink:type,xml:base,xml:lang,` +
`xlink:href,xlink:role,xlink:show,xlink:title,xlink:type,xmlns:xlink,xml:base,xml:lang,` +
`xml:space,y,y1,y2,yChannelSelector,z,zoomAndPan`
)