test(types/defineProps): add failing tests for runtime declaration to align with type declaration #9757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn with type declaration * add tests for Extract*PropTypes ref: vuejs#6421
Size ReportBundles
Usages
|
|
Is the prefix |
DrJume
changed the title
|
/cc @pikax |
edison1105
added
scope: types
🍰 p2-nice-to-have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the types returned by
defineProps()with a runtime declaration don't match the ones from the type declaration.This PR adds failings tests for the types from the runtime declaration to align with the type declaration. The type declaration types were updated in the following PR:
It uses a new
OptionalKeysutility type to check that the internal props type does not have optional keys.Also adding a test for
ExtractDefaultPropTypes.