Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type(reactivity): support distribution of union types #9909

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #9903

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 50 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

Copy link

codspeed-hq bot commented Dec 24, 2023

CodSpeed Performance Report

Merging #9909 will not alter performance

Comparing RicardoErii:feat/setup-ref-type (fa5bf44) with main (a8d0b1b)

Summary

✅ 53 untouched benchmarks

@yangxiuxiu1115 yangxiuxiu1115 changed the title test(reactivity): support distribution of union types type(reactivity): support distribution of union types Dec 25, 2023
@yyx990803
Copy link
Member

Looks like the previous complication was introduced in #4100, which is also fixed by having the extra distribute type, so the distribute type itself can be simplified.

I also added tests in fa5bf44

@yyx990803 yyx990803 merged commit 0695c69 into vuejs:main Dec 26, 2023
13 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the feat/setup-ref-type branch December 26, 2023 03:59
@yangxiuxiu1115
Copy link
Contributor Author

It looks like it is, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union types are not unwrapped properly
2 participants