Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make locales reusable & add zh-Hant locale #365

Merged
merged 16 commits into from
Jan 25, 2024
Merged

feat: make locales reusable & add zh-Hant locale #365

merged 16 commits into from
Jan 25, 2024

Conversation

CoolPlayLin
Copy link
Contributor

No description provided.

@CoolPlayLin CoolPlayLin closed this Nov 4, 2023
@CoolPlayLin CoolPlayLin reopened this Nov 4, 2023
@cexbrayat cexbrayat requested a review from btea November 10, 2023 18:16
@cexbrayat
Copy link
Member

@btea Can you take a look please? I sadly can't read chinese ^^ It looks very similar to zh-CN.json but maybe there are subtleties I don't understand

cexbrayat
cexbrayat previously requested changes Nov 10, 2023
View reviewed changes
locales/zh-TW.json Outdated Show resolved Hide resolved
@CoolPlayLin
Copy link
Contributor Author

@btea Can you take a look please? I sadly can't read chinese ^^ It looks very similar to zh-CN.json but maybe there are subtleties I don't understand

Hi @cexbrayat

One you mentioned is used in China mainland and this file is used in Taiwan. Although they are both Chinese, they have something different. Chinese in China mainland was simplified in order to get education popularized. But in Hong Kong Macao and Taiwan, they still use the traditional Chinese character.

btea
btea reviewed Nov 11, 2023
View reviewed changes
locales/zh-TW.json Outdated Show resolved Hide resolved
@CoolPlayLin CoolPlayLin reopened this Nov 11, 2023
btea
btea approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoolPlayLin
Copy link
Contributor Author

@btea 是不是有必要再增加zh-HK zh-MO zh-SG的本地化文件呢？

@btea
Copy link
Collaborator

btea commented Nov 11, 2023

@CoolPlayLin 我不确定 getLocale 是否有这么细致的划分，你能确定吗？

@CoolPlayLin
Copy link
Contributor Author

@btea 我尝试将系统切换成其他语言查看Intl.DateTimeFormat().resolvedOptions().locale获取的值是否有划分

@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented Nov 11, 2023 •
edited
Loading

Anyway, it returned the expected result after switching language on Windows
image
image

@CoolPlayLin

This comment was marked as outdated.

Sign in to view
@CoolPlayLin CoolPlayLin changed the title feat: Add zh-TW locale feat: add zh-Hant and link it with more locale Nov 11, 2023
@CoolPlayLin CoolPlayLin marked this pull request as draft November 11, 2023 10:18
@CoolPlayLin CoolPlayLin changed the title feat: add zh-Hant and link it with more locale feat: make locales reuseable & add zh-Hant locale Nov 11, 2023
@CoolPlayLin CoolPlayLin marked this pull request as ready for review November 11, 2023 10:33
@CoolPlayLin
Copy link
Contributor Author

@btea 我能想到的只有这个方案了，不知道是否可行

btea
btea reviewed Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoolPlayLin I've added some suggestions for modifications, you can take a look.

utils/getLanguage.ts Outdated Show resolved Hide resolved
utils/getLanguage.ts Outdated Show resolved Hide resolved
utils/getLanguage.ts Show resolved Hide resolved
@CoolPlayLin CoolPlayLin mentioned this pull request Nov 11, 2023
Closed
@CoolPlayLin CoolPlayLin changed the title feat: make locales reuseable & add zh-Hant locale feat: make locales reusable & add zh-Hant locale Nov 11, 2023
haoqunjiang
haoqunjiang requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我不太熟悉港台的相關術語，@johnsoncodehk @antfu 能否麻煩幫忙審閱一下？這兩種 locale 能合併嗎？

locales/zh-Hant.json Outdated Show resolved Hide resolved
locales/zh-Hant.json Outdated Show resolved Hide resolved
locales/zh-Hant.json Outdated Show resolved Hide resolved
@CoolPlayLin @haoqunjiang
Update locales/zh-Hant.json
cc427fc 
Co-authored-by: Haoqun Jiang <[email protected]>
@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented Nov 18, 2023 •
edited
Loading

@antfu @johnsoncodehk 能否麻煩查看一下，謝謝

antfu
antfu approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@antfu antfu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我了解的台湾术语翻译有限，但 Overall looks good

locales/zh-Hant.json Outdated Show resolved Hide resolved
locales/zh-Hant.json Outdated Show resolved Hide resolved
@CoolPlayLin
Copy link
Contributor Author

Any update?@cexbrayat @sodatea

@cexbrayat
Copy link
Member

I'll let @sodatea check this one, as I can't help with these locales

@haoqunjiang
Copy link
Member

We still need someone familiar with Hong Kong technology terms to review this PR.
I don't feel confident about merging these locales.

@CoolPlayLin
Copy link
Contributor Author

We still need someone familiar with Hong Kong technology terms to review this PR.

Could someone take a look? Thanks!

CC @ygj6 @yoyo930021

yoyo930021
yoyo930021 reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@yoyo930021 yoyo930021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some words would be better

locales/zh-Hant.json Outdated Show resolved Hide resolved
locales/zh-Hant.json Outdated Show resolved Hide resolved
@CoolPlayLin CoolPlayLin mentioned this pull request Dec 9, 2023
Closed
yoyo930021
yoyo930021 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@yoyo930021 yoyo930021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haoqunjiang
Copy link
Member

We still haven't got a review on the zh-HK locale.
But I think we need to move forward now, and we can revert when there are real user complaints.

Thanks for the contribution and patience!

@haoqunjiang haoqunjiang merged commit 5f68aaa into vuejs:main Jan 25, 2024
101 checks passed
@CoolPlayLin CoolPlayLin deleted the CoolPlayLin/locale-zh-TW branch January 25, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@antfu antfu antfu approved these changes

@yoyo930021 yoyo930021 yoyo930021 approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

@cexbrayat cexbrayat Awaiting requested review from cexbrayat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CoolPlayLin @cexbrayat @btea @haoqunjiang @yoyo930021 @antfu