Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct the 'build' command in the package.json file. #394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mishengqiang
Copy link

@mishengqiang mishengqiang commented Nov 30, 2023

The package.json file is located at template/config/typescript/package.json.

run-p type-check \"build-only {@}\" -- -> run-p type-check \"build-only -- {@}\" --

#393

The package.json file is located at template/config/typescript/package.json.
@mishengqiang mishengqiang changed the title Correct the 'build' command in the package.json file. fix: Correct the 'build' command in the package.json file. Nov 30, 2023
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes commands like npm run build -- --sourcemap, but it no longer works with pnpm run build --sourcemap because it adds an extra --

@sodatea WDYT?

@mishengqiang
Copy link
Author

Ah, I didn't consider pnpm and yarn. After testing, yarn performs the best – it passes parameters as expected regardless of whether -- is added or not. npm requires an extra -- to pass parameters as expected. pnpm doesn't need an extra -- to pass parameters as expected.

image

The image below demonstrates when an extra '--' is added.
image

@cexbrayat
Copy link
Member

Yes, that's why I don't know if we should change the default or not, or maybe there is a way to make it work with all package managers?

@haoqunjiang
Copy link
Member

Yeah, I think this should be resolved in the upstream npm-run-all2 package instead.
Before that, maybe we can add a note in the generated README?

@ayu-exorcist
Copy link

Yeah, I think this should be resolved in the upstream npm-run-all2 package instead. Before that, maybe we can add a note in the generated README?

I resolved it in the bcomnes/npm-run-all2#143.

We can run run-p type-check \"build-only -- {@}\" -- on npm/yarn/pnpm when the PR is merged

@ayu-exorcist
Copy link

ayu-exorcist commented Jul 4, 2024

Yeah, I think this should be resolved in the upstream npm-run-all2 package instead. Before that, maybe we can add a note in the generated README?

I resolved it in the bcomnes/npm-run-all2#143.

We can run run-p type-check \"build-only -- {@}\" -- on npm/yarn/pnpm when the PR is merged

Already merged in npm-run-all2 v6.2.1

We can try to merge this PR now!

@bcomnes
Copy link

bcomnes commented Jul 4, 2024

Turns out this was a breaking change so I reverted. I need to consider this change a little bit more and at a minimum, put it out in a major release with notes on upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants