Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuex: keep inspected mutation selected if there is a new mutation #925

Closed
robokozo opened this issue Mar 26, 2019 · 6 comments
Closed

Vuex: keep inspected mutation selected if there is a new mutation #925

robokozo opened this issue Mar 26, 2019 · 6 comments

Comments

@robokozo
Copy link

Version

5.0.3

Browser and OS info

Chrome / Windows 10

Steps to reproduce

  1. Create a Vuex enabled App
  2. In a created component, create an setInterval that updates the state via a mutation at a regular interval
  3. Try to inspect the Vuex state

What is expected?

If an entry in the vuex log is explicitly clicked on to be inspected, it shouldn't be changed due to a mutation.

What is actually happening?

When a mutation occurs the 'inspected' Vuex item is updated to the latest value


I added a screen capture of what is occurring here: https://imgur.com/a/QfKAI9N

@robokozo
Copy link
Author

vuex-bug

The screen capture

@Akryum Akryum changed the title The 'inspected' Vuex state is set to the latest version of the state anytime there is a mutation Vuex: keep inspected mutation selected if there is a new mutation Mar 26, 2019
@jacobg
Copy link

jacobg commented Apr 1, 2019

IMHO Seems more like a bug than an enhancement, since viewing state is pretty much unusable, and it’s also a regression of behaviorfrom prior dev tools version.

@robokozo
Copy link
Author

robokozo commented Apr 1, 2019

I have to agree with @jacobg
Our only solution at the moment is to disable the time based features of our app in order to get any use out of the Vuex tab.

@Akryum
Copy link
Member

Akryum commented Apr 5, 2019

@jacobg Git agrees with me that the inspected mutation was always reset to the last one when a mutation was received, even 2 years ago 😸️

Screenshot from 2019-04-05 13-39-46

@Akryum Akryum closed this as completed in 116ded5 Apr 5, 2019
@jacobg
Copy link

jacobg commented Apr 5, 2019

@Akryum Thanks for resolving. I thought I remember in the old version I could look at state even when new mutations come in. Perhaps the state was getting updated with new mutations. The current version changes to Loading State spinner when new mutation comes in.

@Akryum
Copy link
Member

Akryum commented Apr 5, 2019

@jacobg I think your are talking about something different, OP was about selecting a mutation other than the last one and keeping it selected when a new mutation is received.

simsim0709 pushed a commit to simsim0709/vue-devtools that referenced this issue May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants