Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if third party cookies are blocked #979

Closed
GarrettGeorge opened this issue Apr 19, 2019 · 16 comments
Closed

Crash if third party cookies are blocked #979

GarrettGeorge opened this issue Apr 19, 2019 · 16 comments

Comments

@GarrettGeorge
Copy link

Version

5.1.0

Browser and OS info

Chrome 73.0.3683.103 / Windows 10

Steps to reproduce

  1. Open Chrome Dev Tools
  2. Click on Vue tab
  3. Click on settings, vuex state, or other tabs

What is expected?

Anything to happen.

What is actually happening?

Nothing happens.

@GarrettGeorge
Copy link
Author

Would like an update on this, vue-dev-tools is completely broken and unusable for me.

@GarrettGeorge
Copy link
Author

After trying again, it works initially but breaks the moment I click on the settings button.

@index23
Copy link

index23 commented Apr 24, 2019

I have similar situation.

Extension version: 5.1.0
Browser: Chrome Version 73.0.3683.103 (Official Build) (64-bit)
OS: macOS Mojave Version 10.14.3

Steps to reproduce

  1. Open Chrome Dev Tools
  2. Click on Vue tab

What is expected?
Everything to work fine and fluently.

What is actually happening?
Entire browser tab and devtool is frozen and broken.

My solution is to install previous version ( 5.0.0) where almost everything works as expected.

@DespertaWeb
Copy link

where can I get the 5.0.0 v ? @index23

@nickdex
Copy link

nickdex commented Apr 24, 2019

Can confirm happens with Vivaldi (Chromium 73.0.3683.105) on Linux and MacOS Mojave. Everything works fine until settings icon is clicked.
@DespertaWeb You can get releases from releases tab and follow steps for manual installation

@Akryum
Copy link
Member

Akryum commented Apr 24, 2019

I can't reproduce on Chrome 73.0.3683.103 / Win 10.

@Akryum Akryum added the cannot reproduce We cannot reproduce the problem with the given information. More env information needed. label Apr 24, 2019
@benediktvolke
Copy link

Same problem here:

Extension version: 5.1.0
Browser: Chrome 74.0.3729.108
OS: Windows 10 Pro (1809)

Steps to reproduce

  1. Open Chrome Dev Tools
  2. Click on Vue Tab
  3. Click on Settings inside Vue Tab

What is expected?

Settings tab opens

What is actually happening?

Browser Tab and Chrome Dev Tools freeze.

Version 5.0.5 is working just fine.

@Akryum
Copy link
Member

Akryum commented Apr 25, 2019

Could you right-click on the devtools, select Inspect (or similar) and share the content of the console in the opened chrome devtools window?

@benediktvolke
Copy link

shell.js:7997 Main._createAppUI: 76.946044921875ms
shell.js:7997 Main._showAppUI: 84.51611328125ms
shell.js:7997 Main._initializeTarget: 26.43798828125ms
shell.js:7997 Main._lateInitialization: 11.224853515625ms
devtools.js:7 TypeError: Cannot read property '$options' of undefined
    at ow.c.r.a.config.errorHandler (devtools.js:51)
    at ie (devtools.js:7)
    at ne (devtools.js:7)
    at Array.<anonymous> (devtools.js:7)
    at le (devtools.js:7)
devtools.js:7 DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
    at a.provide (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:51:13275)
    at Le (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:15082)
    at a.t._init (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:34428)
    at new a (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:35694)
    at an (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:21615)
    at init (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:20481)
    at p (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:44114)
    at h (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:43743)
    at H (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:46346)
    at L (chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/build/devtools.js:7:47135)

@Akryum
Copy link
Member

Akryum commented Apr 25, 2019

Are you blocking third-party cookies?

@DKhalil
Copy link

DKhalil commented Apr 25, 2019

Same issue here, and yes I'm blocking third-party cookies

@Akryum
Copy link
Member

Akryum commented Apr 25, 2019

That's the reason then. We may need to refactor the extension to use chrome.storage instead of localStorage.

@nickdex
Copy link

nickdex commented Apr 25, 2019

@Akryum I unchecked "Block 3rd Party Cookies" and now its working.
It was on by default, and I imagine it would be same for more browsers in future.

@Akryum Akryum changed the title Clicking anything in Vue tab doesn't work Crash if third party cookies are blocked Apr 25, 2019
@Akryum Akryum added bug priority: high and removed cannot reproduce We cannot reproduce the problem with the given information. More env information needed. labels Apr 25, 2019
@DespertaWeb
Copy link

DespertaWeb commented May 10, 2019

Back to v5 and up & running!
great! thanx @nickdex

PS: btw there's a lot of people, and more to come, that block 3rd party spy shit. Please fix it asap @Akryum.

@Akryum Akryum closed this as completed in bb1569c Jun 25, 2019
@hailwood
Copy link

@Akryum Appreciate you putting in the work to fix this.

When do you think this might be released (week, month, 3 month?)?
I'd really like to turn third party cookies back off!

@hay
Copy link

hay commented Sep 9, 2019

What worked for me is to add an exception for the Extension URL.

Go to Settings --> Advanced --> Site settings --> Cookies.
With 'Block third-party cookies' enabled press the 'Add' button next to allow and enter chrome-extension://nhdogjmejiglipccpnnnanhbledajbpd/. Click add.

You should now see a 'Vue devtools' icon in the list of allowed cookies. Reload Devtools and you should be able to go to the settings tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants