Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#773: Fix payload on replaying mutation #829

Merged
merged 3 commits into from
Jan 25, 2019
Merged

#773: Fix payload on replaying mutation #829

merged 3 commits into from
Jan 25, 2019

Conversation

sp1ker
Copy link
Contributor

@sp1ker sp1ker commented Nov 18, 2018 •
edited by Akryum
Loading

closes #773 , closes #792, closes #802
All handlers are wrappedMutationHandler with only 1 argument - payload

@sp1ker sp1ker changed the title Fix payload on replaying mutation fix: Fix payload on replaying mutation Nov 18, 2018
@sp1ker sp1ker changed the title fix: Fix payload on replaying mutation #802: Fix payload on replaying mutation Nov 19, 2018
@sp1ker sp1ker changed the title #802: Fix payload on replaying mutation #773: Fix payload on replaying mutation Nov 19, 2018
@sp1ker sp1ker mentioned this pull request Nov 19, 2018
Closed
davidpelayo
davidpelayo approved these changes Nov 19, 2018
View reviewed changes
Copy link

@davidpelayo davidpelayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@sp1ker sp1ker mentioned this pull request Nov 20, 2018
Open
@Binaryify
Copy link

Binaryify commented Nov 21, 2018 •
edited
Loading

Finally it can work now~👍

@harrywynnwill
Copy link

please merge!

@nhynes
Copy link

nhynes commented Nov 26, 2018

+1

@tochoromero
Copy link

I built this branch and I got the same results :(
The state does not load, it just stays in "Loading State" forever.

@davidpelayo
Copy link

@tochoromero it could be an issue with your store shape. It happened the same to me. It was an issue on my side with the usage of the Vue.i18n plugin. I did built this branch and works fine for me.

@tochoromero
Copy link

@davidpelayo I'm not using Vue.i18n, my store is pretty vanilla, other than using dynamic modules

@davidpelayo
Copy link

Is this at any point going to be merged?

@ellisio
Copy link

ellisio commented Dec 4, 2018 •
edited
Loading

We have a rather complex dynamic module store and this branch allowed the devtools to start working again for us. Would be awesome to get this merged so I can reinstall the official beta package.

@iamareebjamal
Copy link

Guys, please merge this as debugging has become very difficult for us without this fix.

@sp1ker sp1ker mentioned this pull request Jan 22, 2019
Closed
@Akryum Akryum merged commit 8035e4c into vuejs:dev Jan 25, 2019
simsim0709 pushed a commit to simsim0709/vue-devtools that referenced this pull request May 7, 2019
@sp1ker @Akryum
fix: payload on replaying mutation, closes vuejs#773 , closes vuejs#792…
92163cf 
…, closes vuejs#802 (vuejs#829)

* test(e2e): test mutation payload

* Fix payload on replaying mutation

* test(e2e): fix expect


Co-authored-by: Guillaume Chau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpelayo davidpelayo davidpelayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vuex panel display state recursively Time travel passes state instead of payload Vuex state not loading
9 participants
@sp1ker @Binaryify @harrywynnwill @nhynes @tochoromero @davidpelayo @ellisio @iamareebjamal @Akryum